Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: src/objects.h

Issue 1375003002: Teach JSReceiver::GetKeys() how to include symbols (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/objects.cc » ('j') | src/objects.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index 225a7db42e0cfab92c786cea07095731304ffa22..6a88b0e3dc6ebb5f0a281c75ff9fa95ed37064c2 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -1850,12 +1850,13 @@ class JSReceiver: public HeapObject {
Handle<JSReceiver> object);
enum KeyCollectionType { OWN_ONLY, INCLUDE_PROTOS };
+ enum IncludeSymbolNamedProperties { SKIP_SYMBOLS, INCLUDE_SYMBOLS };
Camillo Bruni 2015/09/29 16:27:20 Maybe use FixedArray::NON_SYMBOL_KEYS instead (or
Jakob Kummerow 2015/09/30 13:59:30 Done.
// Computes the enumerable keys for a JSObject. Used for implementing
// "for (n in object) { }".
MUST_USE_RESULT static MaybeHandle<FixedArray> GetKeys(
- Handle<JSReceiver> object,
- KeyCollectionType type);
+ Handle<JSReceiver> object, KeyCollectionType type,
+ IncludeSymbolNamedProperties include_symbols = SKIP_SYMBOLS);
private:
DISALLOW_IMPLICIT_CONSTRUCTORS(JSReceiver);
« no previous file with comments | « no previous file | src/objects.cc » ('j') | src/objects.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698