Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1374953002: Remove Resource class and support functions.

Created:
5 years, 2 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, floitsch, mit
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove Resource class and support functions. The Resource class will be introduced in a package instead, based on functionality added to the isolate library.

Patch Set 1 #

Patch Set 2 : Remove reference to resource class in dart2js compiler. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -478 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
D pkg/package_test_data/lib/resources/sample.txt View 1 chunk +0 lines, -1 line 0 comments Download
D pkg/package_test_data/pubspec.yaml View 1 chunk +0 lines, -7 lines 0 comments Download
M runtime/bin/builtin.dart View 2 chunks +0 lines, -12 lines 1 comment Download
M runtime/lib/core_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/lib/internal_patch.dart View 1 chunk +0 lines, -2 lines 0 comments Download
D runtime/lib/resource_patch.dart View 1 chunk +0 lines, -68 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/core_patch.dart View 1 chunk +0 lines, -101 lines 0 comments Download
M sdk/lib/core/core.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/core/core_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D sdk/lib/core/resource.dart View 1 chunk +0 lines, -55 lines 0 comments Download
D tests/corelib/data_resource_test.dart View 1 chunk +0 lines, -51 lines 0 comments Download
D tests/corelib/file_resource_test.dart View 1 chunk +0 lines, -63 lines 0 comments Download
D tests/corelib/http_resource_test.dart View 1 chunk +0 lines, -62 lines 0 comments Download
D tests/corelib/package_resource_test.dart View 1 chunk +0 lines, -48 lines 0 comments Download
M tests/try/poi/serialize_test.dart View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Lasse Reichstein Nielsen
5 years, 2 months ago (2015-09-29 13:01:25 UTC) #2
floitsch
LGTM. Not sure if we should wait until the package is ready (so we are ...
5 years, 2 months ago (2015-09-29 13:39:10 UTC) #4
Siggi Cherem (dart-lang)
+het@ lgtm
5 years, 2 months ago (2015-09-29 16:21:16 UTC) #6
Lasse Reichstein Nielsen
I plan to wait until the Resource package is ready (which is waiting for the ...
5 years, 2 months ago (2015-09-30 11:04:52 UTC) #7
Ivan Posva
LGTM -Ivan https://codereview.chromium.org/1374953002/diff/20001/runtime/bin/builtin.dart File runtime/bin/builtin.dart (left): https://codereview.chromium.org/1374953002/diff/20001/runtime/bin/builtin.dart#oldcode643 runtime/bin/builtin.dart:643: _loadData(_Dart_kResourceLoad, uri.toString(), uri, completer); This was the ...
5 years, 2 months ago (2015-10-05 12:49:19 UTC) #9
Ivan Posva
On 2015/09/30 11:04:52, Lasse Reichstein Nielsen wrote: > I plan to wait until the Resource ...
5 years, 2 months ago (2015-10-05 12:50:00 UTC) #10
sethladd
5 years, 2 months ago (2015-10-07 16:49:45 UTC) #11
Please don't actually delete Resource in 1.13. We've marked it as Deprecated, to
be deleted in 1.14. We want to give developers one release cycle to migrate to
the package.

Powered by Google App Engine
This is Rietveld 408576698