Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/analyzer/lib/src/generated/incremental_resolver.dart

Issue 1374943005: Fix for 'implemented' notification after an incremental change. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Put new content into 'testCode'. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pkg/analysis_server/test/analysis/notification_implemented_test.dart ('K') | « pkg/analysis_server/test/analysis/notification_implemented_test.dart ('k') | pkg/analyzer/test/generated/incremental_resolver_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/incremental_resolver.dart
diff --git a/pkg/analyzer/lib/src/generated/incremental_resolver.dart b/pkg/analyzer/lib/src/generated/incremental_resolver.dart
index 46cd6773cb6989a83061664f823ddf530d2267d5..dfcff7e8d80e15cd892bd6dcb5b9d0bcdee03da1 100644
--- a/pkg/analyzer/lib/src/generated/incremental_resolver.dart
+++ b/pkg/analyzer/lib/src/generated/incremental_resolver.dart
@@ -1044,8 +1044,6 @@ class IncrementalResolver {
_context.invalidateLibraryHints(_librarySource);
// update entry errors
_updateEntry();
- // notify unit
- _definingUnit.afterIncrementalResolution();
// OK
return true;
} finally {
@@ -1279,6 +1277,7 @@ class IncrementalResolver {
try {
_definingUnit
.accept(new _ElementNameOffsetUpdater(_updateOffset, _updateDelta));
+ _definingUnit.afterIncrementalResolution();
} finally {
timer.stop('update element offsets');
}
« pkg/analysis_server/test/analysis/notification_implemented_test.dart ('K') | « pkg/analysis_server/test/analysis/notification_implemented_test.dart ('k') | pkg/analyzer/test/generated/incremental_resolver_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698