Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: scripts/slave/recipe_modules/isolate/api.py

Issue 1374943002: isolate: add run_isolated, deprecate runtest (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: fixes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/isolate/example.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/isolate/api.py
diff --git a/scripts/slave/recipe_modules/isolate/api.py b/scripts/slave/recipe_modules/isolate/api.py
index e96b289d1928917bb5041e18532181789bb7cffd..a896d851ae363de75193bf525c959d553d603f7e 100644
--- a/scripts/slave/recipe_modules/isolate/api.py
+++ b/scripts/slave/recipe_modules/isolate/api.py
@@ -213,11 +213,25 @@ class IsolateApi(recipe_api.RecipeApi):
full_args.extend(args)
return full_args
+ def run_isolated(self, name, isolate_hash, args=None):
+ """Runs an isolated test."""
+ cmd = [
+ '--isolated', isolate_hash,
+ '-I', self.isolate_server,
+ '--verbose',
+ ]
+ if args:
+ cmd.append('--')
+ cmd.extend(args)
+ self.m.python(name, self._run_isolated_path, cmd)
+
def runtest(self, test, revision, webkit_revision, args=None, name=None,
**runtest_kwargs):
"""Runs a test which has previously been isolated to the server.
Uses runtest_args_list, above, and delegates to api.chromium.runtest.
+
+ DEPRECATED - run_isolated above is strongly recommended for all new callers.
"""
self.m.chromium.runtest(
self._run_isolated_path,
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/isolate/example.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698