Retry HttpNetworkTransactions upon receipt of ERR_NETWORK_CHANGED during host resolution and …

net/url_request/url_request.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_URL_REQUEST_URL_REQUEST_H_
 #define NET_URL_REQUEST_URL_REQUEST_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 660 matching lines @@
 
   // Sets the priority level for this request and any related
   // jobs. Must not change the priority to anything other than
   // MAXIMUM_PRIORITY if the IGNORE_LIMITS load flag is set.
   void SetPriority(RequestPriority priority);
 
   // Returns true iff this request would be internally redirected to HTTPS
   // due to HSTS. If so, |redirect_url| is rewritten to the new HTTPS URL.
   bool GetHSTSRedirect(GURL* redirect_url) const;
 
+  // Retries up to |max_retries| times when requests fail with
+  // ERR_NETWORK_CHANGED. If ERR_NETWORK_CHANGED is received after having
+  // retried |max_retries| times then it is propagated to the Delegate.
+  // Retrying is only attempted when ERR_NETWORK_CHANGED is received during
+  // host resolution or connecting (i.e. before the request has been issued).
+  // This ensures request side-effects are never duplicated. The default
+  // number of automatic retries upon ERR_NEWORK_CHANGED is three. This only
+  // has an effect if the underlying URLRequestJob implements this behavior.
+  void set_max_automatic_retries_on_network_changes(int max_retries) {
+    max_automatic_retries_on_network_changes_ = max_retries;
+  }
+  int max_automatic_retries_on_network_changes() const {

[mmenke, 2014/02/13 20:20:17]

Don't think we need an accessor, for now.  Not a huge deal, just prefer to
minimize public APIs until we know they're needed.

+    return max_automatic_retries_on_network_changes_;
+  }
+
   // TODO(willchan): Undo this. Only temporarily public.
   bool has_delegate() const { return delegate_ != NULL; }
 
   // NOTE(willchan): This is just temporary for debugging
   // http://crbug.com/90971.
   // Allows to setting debug info into the URLRequest.
   void set_stack_trace(const base::debug::StackTrace& stack_trace);
   const base::debug::StackTrace* stack_trace() const;
 
   void set_received_response_content_length(int64 received_content_length) {
@@ skipping 194 matching lines @@
   // TODO(battre): Remove this. http://crbug.com/89049
   bool has_notified_completion_;
 
   // Authentication data used by the NetworkDelegate for this request,
   // if one is present. |auth_credentials_| may be filled in when calling
   // |NotifyAuthRequired| on the NetworkDelegate. |auth_info_| holds
   // the authentication challenge being handled by |NotifyAuthRequired|.
   AuthCredentials auth_credentials_;
   scoped_refptr<AuthChallengeInfo> auth_info_;
 
+  int max_automatic_retries_on_network_changes_;
+
   int64 received_response_content_length_;
 
   base::TimeTicks creation_time_;
 
   // Timing information for the most recent request.  Its start times are
   // populated during Start(), and the rest are populated in OnResponseReceived.
   LoadTimingInfo load_timing_info_;
 
   scoped_ptr<const base::debug::StackTrace> stack_trace_;
 
   // Keeps track of whether or not OnBeforeNetworkStart has been called yet.
   bool notified_before_network_start_;
 
   DISALLOW_COPY_AND_ASSIGN(URLRequest);
 };
 
 }  // namespace net
 
 #endif  // NET_URL_REQUEST_URL_REQUEST_H_