Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 137493007: Revert 245865 "Revert of Reenable linux_aura on the main builder..." (Closed)

Created:
6 years, 11 months ago by jam
Modified:
6 years, 11 months ago
Reviewers:
eustas
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 245865 "Revert of Reenable linux_aura on the main builder..." We've switched to Aura on Linux (see chromium-dev threads). NPAPI plugins aren't supported on Linux Aura (also see chromium-dev thread). These tests should just be disabled. > Revert of Reenable linux_aura on the main builders. (Again). (https://codereview.chromium.org/138033023/) > > Reason for revert: > Blink layout tests are failing: > > http/tests/plugins/interrupted-get-url.html > http/tests/plugins/third-party-cookie-accept-policy.html > plugins/mouse-click-plugin-clears-selection.html > > Original issue's description: > > Reenable linux_aura on the main builders. (Again). > > > > We upgraded the eu-strip binary so that it can deal with binaries that > > are more than two gigabytes large. This should fix the crash on the > > Google Chrome Linux builder, which was the only bot to break last night. > > > > BUG=319075, 125106, 303342, 318961 > > NOTRY=True > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245737 > > TBR=erg@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=319075, 125106, 303342, 318961 > > Review URL: https://codereview.chromium.org/143073002 TBR=eustas@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246094

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -6 lines) Patch
M trunk/src/build/common.gypi View 1 chunk +8 lines, -0 lines 0 comments Download
M trunk/src/chrome/installer/linux/debian/expected_deps View 3 chunks +4 lines, -3 lines 0 comments Download
M trunk/src/chrome/installer/linux/rpm/expected_deps_i386 View 3 chunks +3 lines, -1 line 0 comments Download
M trunk/src/chrome/installer/linux/rpm/expected_deps_x86_64 View 3 chunks +3 lines, -1 line 0 comments Download
M trunk/src/ppapi/native_client/tests/breakpad_crash_test/nacl.scons View 1 chunk +6 lines, -1 line 0 comments Download
M trunk/src/tools/lsan/suppressions.txt View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
6 years, 11 months ago (2014-01-21 20:02:46 UTC) #1
mmoss
I think Aura is causing Blink Linux trybots webkit_unit_tests to break, with: [0121/123117:FATAL:message_pump_x11.cc(231)] Check failed: ...
6 years, 11 months ago (2014-01-21 23:41:30 UTC) #2
jam
Adding some Linux folks. guys: is there some object that needs to be setup for ...
6 years, 11 months ago (2014-01-21 23:47:54 UTC) #3
jam
6 years, 11 months ago (2014-01-22 00:03:15 UTC) #4
Message was sent while issue was closed.
On 2014/01/21 23:47:54, jam wrote:
> Adding some Linux folks. guys: is there some object that needs to be setup
> for this test harness?

nvm, looks like fix just landed: https://codereview.chromium.org/144413002/

Powered by Google App Engine
This is Rietveld 408576698