Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 137493006: Revert r156303 as non-Aura Metro mode is gone (Closed)

Created:
6 years, 11 months ago by yukawa
Modified:
6 years, 10 months ago
Reviewers:
cpu_(ooo_6.6-7.5), sky, Jói
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, jam, msw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert r156303 as non-Aura Metro mode is gone We no longer need to support TSF in the browser code. Now TSF-related code is completely consolidated into the metro_driver process and the browser process doesn't need to know about TSF any more. Note: TSF-related code remaining in base/win/metro.{cc, h} and content/browser/browser_main_runner.{h, cc} will be reverted by subsequent CLs. BUG=319122, 330735 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248475

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -53 lines) Patch
M base/win/metro.h View 1 chunk +0 lines, -7 lines 0 comments Download
M base/win/metro.cc View 2 chunks +1 line, -33 lines 0 comments Download
M content/browser/browser_main_runner.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
yukawa
Hi Carlos and Scott, Could you take a look at following files? cpu: base/win/metro.h base/win/metro.cc ...
6 years, 10 months ago (2014-01-30 03:18:04 UTC) #1
sky
LGTM
6 years, 10 months ago (2014-01-30 04:24:30 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm How about the TSF code that hooks the message loop (TextServicesMessageFilter), is that going ...
6 years, 10 months ago (2014-01-31 21:40:11 UTC) #3
scottmg
On 2014/01/31 21:40:11, cpu wrote: > lgtm > > How about the TSF code that ...
6 years, 10 months ago (2014-01-31 21:43:10 UTC) #4
scottmg
On 2014/01/31 21:43:10, scottmg wrote: > On 2014/01/31 21:40:11, cpu wrote: > > lgtm > ...
6 years, 10 months ago (2014-01-31 21:44:27 UTC) #5
yukawa
On 2014/01/31 21:40:11, cpu wrote: > lgtm > > How about the TSF code that ...
6 years, 10 months ago (2014-02-01 13:31:57 UTC) #6
yukawa
The CQ bit was checked by yukawa@chromium.org
6 years, 10 months ago (2014-02-01 13:32:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukawa@chromium.org/137493006/90001
6 years, 10 months ago (2014-02-01 13:32:15 UTC) #8
yukawa
+joi in case content/public/common/content_switches.{h, cc} require his approval. joi@: Could you take a look at ...
6 years, 10 months ago (2014-02-01 13:54:36 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-01 13:57:33 UTC) #10
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=47558
6 years, 10 months ago (2014-02-01 13:57:33 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 13:57:37 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 13:57:44 UTC) #13
Jói
//content/public LGTM
6 years, 10 months ago (2014-02-03 10:11:19 UTC) #14
yukawa
The CQ bit was checked by yukawa@chromium.org
6 years, 10 months ago (2014-02-03 10:13:17 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukawa@chromium.org/137493006/90001
6 years, 10 months ago (2014-02-03 10:13:25 UTC) #16
commit-bot: I haz the power
Change committed as 248475
6 years, 10 months ago (2014-02-03 11:45:06 UTC) #17
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 11:45:12 UTC) #18
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 11:45:16 UTC) #19
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698