Hook up ARM architecture flags to GN build.

Hook up ARM architecture flags to GN build.

This duplicates the ARM architecture logic from common.gypi.

R=scottmg@chromium.org
TBR=scottmg

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244782

[scottmg, 2014-01-13 23:47:20]

lgtm

https://codereview.chromium.org/137493004/diff/1/build/config/compiler/BUILD.gn
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/137493004/diff/1/build/config/compiler/BUILD....
build/config/compiler/BUILD.gn:116: cflags += "-mtune=$arm_tune"
[ ] around here like below?

[brettw, 2014-01-13 23:50:21]

https://codereview.chromium.org/137493004/diff/1/build/config/compiler/BUILD.gn
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/137493004/diff/1/build/config/compiler/BUILD....
build/config/compiler/BUILD.gn:116: cflags += "-mtune=$arm_tune"
On 2014/01/13 23:47:20, scottmg wrote:
> [ ] around here like below?

Thanks, I'm trying to be consistent about this. Do you think I should change the
language syntax to disallow list + string to eliminate this option?

[scottmg, 2014-01-13 23:56:55]

https://codereview.chromium.org/137493004/diff/1/build/config/compiler/BUILD.gn
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/137493004/diff/1/build/config/compiler/BUILD....
build/config/compiler/BUILD.gn:116: cflags += "-mtune=$arm_tune"
On 2014/01/13 23:50:22, brettw wrote:
> On 2014/01/13 23:47:20, scottmg wrote:
> > [ ] around here like below?
> 
> Thanks, I'm trying to be consistent about this. Do you think I should change
the
> language syntax to disallow list + string to eliminate this option?

Yes, I think that'd be a good idea. It sort of seems nice at first, but I think
it ends up being a bit confusing and you end up reading it multiple times,
especially if you're not sure what the type of the LHS is.

[brettw, 2014-01-14 18:56:56]

Committed patchset #1 manually as r244782 (presubmit successful).