Cache OpenGL textures and other objects in CompositingIOSurfaceMac copy/transform code.

content/browser/renderer_host/compositing_iosurface_transformer_mac_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/compositing_iosurface_transformer_mac.h"
 
 #include <OpenGL/CGLCurrent.h>
 #include <OpenGL/CGLRenderers.h>
 #include <OpenGL/CGLTypes.h>
 #include <OpenGL/OpenGL.h>
@@ skipping 262 matching lines @@
     // unit tests, once it's established that the trybots and buildbots behave
     // well when using the GPU.
     CHECK(InitializeGLContext(&context_, RESTRICTION_SOFTWARE_ONLY));
     CGLSetCurrentContext(context_);
     shader_program_cache_.reset(new CompositingIOSurfaceShaderPrograms());
     transformer_.reset(new CompositingIOSurfaceTransformer(
         kGLTextureTarget, false, shader_program_cache_.get()));
   }
 
   virtual ~CompositingIOSurfaceTransformerTest() {
+    transformer_->ReleaseCachedGLObjects();
     shader_program_cache_->Reset();
     CGLSetCurrentContext(NULL);
     CGLDestroyContext(context_);
   }
 
  protected:
   void RunResizeTest(const SkBitmap& src_bitmap, const gfx::Rect& src_rect,
                      const gfx::Size& dst_size) {
     SCOPED_TRACE(::testing::Message()
-                 << "src_rect=" << src_rect.x() << ',' << src_rect.y()
+                 << "src_rect=(" << src_rect.x() << ',' << src_rect.y()
                  << ")x[" << src_rect.width() << 'x' << src_rect.height()
                  << "]; dst_size=[" << dst_size.width() << 'x'
                  << dst_size.height() << ']');
 
+    // Do the scale operation on the GPU.
     const GLuint original_texture = CreateTextureWithImage(src_bitmap);
-    EXPECT_NE(0u, original_texture);
-
-    // Do the scale operation on the GPU.
+    ASSERT_NE(0u, original_texture);
     GLuint scaled_texture = 0u;
-    EXPECT_TRUE(transformer_->ResizeBilinear(
+    ASSERT_TRUE(transformer_->ResizeBilinear(
         original_texture, src_rect, dst_size, &scaled_texture));
     EXPECT_NE(0u, scaled_texture);
     CGLFlushDrawable(context_);  // Account for some buggy driver impls.
     const SkBitmap result_bitmap = ReadBackTexture(scaled_texture, dst_size);
-
-    // Delete the textures.
     EXPECT_NO_GL_ERROR(glDeleteTextures(1, &original_texture));
-    EXPECT_NO_GL_ERROR(glDeleteTextures(1, &scaled_texture));
 
     // Compare the image read back to the version produced by a known-working
     // software implementation.  Allow up to 2 lines of mismatch due to how
     // implementations disagree on resolving the processing of edges.
     const SkBitmap expected_bitmap =
         ScaleBitmapWithSkia(src_bitmap, src_rect, dst_size);
     EXPECT_GE(std::max(expected_bitmap.width(), expected_bitmap.height()) * 2,
               ImageDifference(expected_bitmap, result_bitmap));
   }
 
   void RunTransformRGBToYV12Test(
       const SkBitmap& src_bitmap, const gfx::Rect& src_rect,
       const gfx::Size& dst_size) {
     SCOPED_TRACE(::testing::Message()
-                 << "src_rect=" << src_rect.x() << ',' << src_rect.y()
+                 << "src_rect=(" << src_rect.x() << ',' << src_rect.y()
                  << ")x[" << src_rect.width() << 'x' << src_rect.height()
                  << "]; dst_size=[" << dst_size.width() << 'x'
                  << dst_size.height() << ']');
 
+    // Perform the RGB to YV12 conversion.
     const GLuint original_texture = CreateTextureWithImage(src_bitmap);
-    EXPECT_NE(0u, original_texture);
-
-    // Perform the RGB to YV12 conversion.
+    ASSERT_NE(0u, original_texture);
     GLuint texture_y = 0u;
     GLuint texture_u = 0u;
     GLuint texture_v = 0u;
     gfx::Size packed_y_size;
     gfx::Size packed_uv_size;
-    EXPECT_TRUE(transformer_->TransformRGBToYV12(
+    ASSERT_TRUE(transformer_->TransformRGBToYV12(
         original_texture, src_rect, dst_size,
         &texture_y, &texture_u, &texture_v, &packed_y_size, &packed_uv_size));
     EXPECT_NE(0u, texture_y);
     EXPECT_NE(0u, texture_u);
     EXPECT_NE(0u, texture_v);
     EXPECT_FALSE(packed_y_size.IsEmpty());
     EXPECT_FALSE(packed_uv_size.IsEmpty());
+    EXPECT_NO_GL_ERROR(glDeleteTextures(1, &original_texture));
 
     // Read-back the texture for each plane.
     CGLFlushDrawable(context_);  // Account for some buggy driver impls.
     const SkBitmap result_y_bitmap = ReadBackTexture(texture_y, packed_y_size);
     const SkBitmap result_u_bitmap = ReadBackTexture(texture_u, packed_uv_size);
     const SkBitmap result_v_bitmap = ReadBackTexture(texture_v, packed_uv_size);
 
-    // Delete the textures.
-    EXPECT_NO_GL_ERROR(glDeleteTextures(1, &original_texture));
-    EXPECT_NO_GL_ERROR(glDeleteTextures(1, &texture_y));
-    EXPECT_NO_GL_ERROR(glDeleteTextures(1, &texture_u));
-    EXPECT_NO_GL_ERROR(glDeleteTextures(1, &texture_v));
-
     // Compare the Y, U, and V planes read-back to the version produced by a
     // known-working software implementation.  Allow up to 2 lines of mismatch
     // due to how implementations disagree on resolving the processing of edges.
     const SkBitmap expected_bitmap =
         ScaleBitmapWithSkia(src_bitmap, src_rect, dst_size);
     const gfx::Size dst_uv_size(
         (dst_size.width() + 1) / 2, (dst_size.height() + 1) / 2);
     scoped_ptr<uint8[]> expected_y_plane(
         new uint8[dst_size.width() * dst_size.height()]);
     scoped_ptr<uint8[]> expected_u_plane(
@@ skipping 150 matching lines @@
         dst_size);
     // Subrect resize test: missing top row, and left+right columns in source.
     RunTransformRGBToYV12Test(
         src_bitmap,
         gfx::Rect(1, 1, params.src_width - 2, params.src_height - 1),
         dst_size);
   }
 }
 
 }  // namespace content