Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: net/http/http_util_unittest.cc

Issue 1374883002: Add UMAs for checking header values against RFC 7230 in //net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use StringPiece. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_util_unittest.cc
diff --git a/net/http/http_util_unittest.cc b/net/http/http_util_unittest.cc
index a5c984db66b1f5e46798036e8c1ac3758fab9f81..f1485e6ddedfdf3129e2159ff53d2a4cefad45b2 100644
--- a/net/http/http_util_unittest.cc
+++ b/net/http/http_util_unittest.cc
@@ -1178,4 +1178,27 @@ TEST(HttpUtilTest, NameValuePairsIteratorMissingEndQuote) {
&parser, false, true, std::string(), std::string()));
}
+TEST(HttpUtilTest, IsValidHeaderValueRFC7230) {
+ EXPECT_TRUE(HttpUtil::IsValidHeaderValueRFC7230(""));
+
+ EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230(" "));
+ EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230(" q"));
+ EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230("q "));
+ EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230("\t"));
+ EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230("\tq"));
+ EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230("q\t"));
+
+ EXPECT_TRUE(HttpUtil::IsValidHeaderValueRFC7230("q q"));
+ EXPECT_TRUE(HttpUtil::IsValidHeaderValueRFC7230("q\tq"));
+
+ EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230(std::string("\0", 1)));
+ EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230(std::string("q\0q", 3)));
+ EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230("q\rq"));
+ EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230("q\nq"));
+ EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230("q\x01q"));
+ EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230("q\x7fq"));
+
+ EXPECT_TRUE(HttpUtil::IsValidHeaderValueRFC7230("q\x80q"));
+}
+
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698