Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: net/http/http_util.cc

Issue 1374883002: Add UMAs for checking header values against RFC 7230 in //net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reflect comments. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_util.cc
diff --git a/net/http/http_util.cc b/net/http/http_util.cc
index f1e5143e701a5334499dccc9a814ae4c96d2023b..be79cfc62be04d59d837888944efe49b45a237cb 100644
--- a/net/http/http_util.cc
+++ b/net/http/http_util.cc
@@ -346,6 +346,24 @@ bool HttpUtil::IsValidHeaderValue(const std::string& value) {
}
// static
+bool HttpUtil::IsValidHeaderValueRFC7230(const base::StringPiece& value) {
+ // This empty string is a valid header-value.
+ if (value.empty())
+ return true;
+
+ // Check leading/trailing whitespaces.
+ if (IsLWS(value[0]) || IsLWS(value[value.size() - 1]))
+ return false;
+
+ // Check each octet is |field-vchar|, |SP| or |HTAB|.
+ for (unsigned char c : value) {
+ if (c == 0x7F || (c < 0x20 && c != '\t'))
+ return false;
+ }
+ return true;
+}
+
+// static
std::string HttpUtil::StripHeaders(const std::string& headers,
const char* const headers_to_remove[],
size_t headers_to_remove_len) {

Powered by Google App Engine
This is Rietveld 408576698