Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: net/http/http_util.h

Issue 1374883002: Add UMAs for checking header values against RFC 7230 in //net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_util.h
diff --git a/net/http/http_util.h b/net/http/http_util.h
index 1bb3c93f8ab168152dc75205e00aabcc0d9c30cf..8f21d0e3f232cb0ab1879c4b33a2c83d24ebe44d 100644
--- a/net/http/http_util.h
+++ b/net/http/http_util.h
@@ -80,6 +80,13 @@ class NET_EXPORT HttpUtil {
// a fully RFC-2616-compliant header value validation.
static bool IsValidHeaderValue(const std::string& value);
+ // Returns true if the string is a valid HTTP header value according to
+ // RFC 7230 and doesn't contain CR or LF.
+ // i.e. returns true if the string matches |*field-content| in RFC 7230.
+ static bool IsValidHeaderValueRFC7230(const std::string& value);
+ static bool IsValidHeaderValueRFC7230(std::string::const_iterator value_begin,
+ std::string::const_iterator value_end);
davidben 2015/09/29 16:32:59 This should use a base::StringPiece. Then you don'
hiroshige 2015/09/30 08:19:23 Done.
+
// Strips all header lines from |headers| whose name matches
// |headers_to_remove|. |headers_to_remove| is a list of null-terminated
// lower-case header names, with array length |headers_to_remove_len|.

Powered by Google App Engine
This is Rietveld 408576698