Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: net/http/http_util_unittest.cc

Issue 1374883002: Add UMAs for checking header values against RFC 7230 in //net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reflect comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/http/http_util.cc ('k') | net/url_request/url_request_http_job.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <algorithm> 5 #include <algorithm>
6 6
7 #include "base/strings/string_util.h" 7 #include "base/strings/string_util.h"
8 #include "net/http/http_util.h" 8 #include "net/http/http_util.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
(...skipping 1159 matching lines...) Expand 10 before | Expand all | Expand 10 after
1170 std::string data = "name='value"; 1170 std::string data = "name='value";
1171 HttpUtil::NameValuePairsIterator parser(data.begin(), data.end(), ';'); 1171 HttpUtil::NameValuePairsIterator parser(data.begin(), data.end(), ';');
1172 EXPECT_TRUE(parser.valid()); 1172 EXPECT_TRUE(parser.valid());
1173 1173
1174 ASSERT_NO_FATAL_FAILURE( 1174 ASSERT_NO_FATAL_FAILURE(
1175 CheckNextNameValuePair(&parser, true, true, "name", "value")); 1175 CheckNextNameValuePair(&parser, true, true, "name", "value"));
1176 ASSERT_NO_FATAL_FAILURE(CheckNextNameValuePair( 1176 ASSERT_NO_FATAL_FAILURE(CheckNextNameValuePair(
1177 &parser, false, true, std::string(), std::string())); 1177 &parser, false, true, std::string(), std::string()));
1178 } 1178 }
1179 1179
1180 TEST(HttpUtilTest, IsValidHeaderValueRFC7230) {
1181 EXPECT_TRUE(HttpUtil::IsValidHeaderValueRFC7230(""));
1182
1183 EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230(" "));
1184 EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230(" q"));
1185 EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230("q "));
1186 EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230("\t"));
1187 EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230("\tq"));
1188 EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230("q\t"));
1189
1190 EXPECT_TRUE(HttpUtil::IsValidHeaderValueRFC7230("q q"));
1191 EXPECT_TRUE(HttpUtil::IsValidHeaderValueRFC7230("q\tq"));
1192
1193 EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230(std::string("\0", 1)));
1194 EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230(std::string("q\0q", 3)));
1195 EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230("q\rq"));
1196 EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230("q\nq"));
1197 EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230("q\x01q"));
1198 EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230("q\x7fq"));
1199
1200 EXPECT_TRUE(HttpUtil::IsValidHeaderValueRFC7230("q\x80q"));
1201 }
1202
1180 } // namespace net 1203 } // namespace net
OLDNEW
« no previous file with comments | « net/http/http_util.cc ('k') | net/url_request/url_request_http_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698