Add UMAs for checking header values against RFC 7230 in //net

net/http/http_request_headers.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_request_headers.h"
 
 #include "base/logging.h"
+#include "base/metrics/histogram.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/values.h"
 #include "net/http/http_log_util.h"
 #include "net/http/http_util.h"
 
 namespace net {
 
 const char HttpRequestHeaders::kGetMethod[] = "GET";
@@ skipping 61 matching lines @@
 }
 
 void HttpRequestHeaders::Clear() {
   headers_.clear();
 }
 
 void HttpRequestHeaders::SetHeader(const base::StringPiece& key,
                                    const base::StringPiece& value) {
   DCHECK(HttpUtil::IsValidHeaderName(key.as_string()));
   DCHECK(HttpUtil::IsValidHeaderValue(value.as_string()));
+  UMA_HISTOGRAM_BOOLEAN("Net.HttpRequestHeaderValueValidInRFC7230",
+                        HttpUtil::IsValidHeaderValueRFC7230(value.as_string()));

[davidben, 2015/09/29 16:32:59]

This makes an unnecessary copy. The lines above do too, but they're only
DCHECKs, so it doesn't matter.

[hiroshige, 2015/09/30 08:19:23]

Done by using StringPiece.

   HeaderVector::iterator it = FindHeader(key);
   if (it != headers_.end())
     it->value.assign(value.data(), value.size());
   else
     headers_.push_back(HeaderKeyValuePair(key, value));
 }
 
 void HttpRequestHeaders::SetHeaderIfMissing(const base::StringPiece& key,
                                             const base::StringPiece& value) {
   DCHECK(HttpUtil::IsValidHeaderName(key.as_string()));
   DCHECK(HttpUtil::IsValidHeaderValue(value.as_string()));
+  UMA_HISTOGRAM_BOOLEAN("Net.HttpRequestHeaderValueValidInRFC7230",
+                        HttpUtil::IsValidHeaderValueRFC7230(value.as_string()));
   HeaderVector::iterator it = FindHeader(key);
   if (it == headers_.end())
     headers_.push_back(HeaderKeyValuePair(key, value));
 }
 
 void HttpRequestHeaders::RemoveHeader(const base::StringPiece& key) {
   HeaderVector::iterator it = FindHeader(key);
   if (it != headers_.end())
     headers_.erase(it);
 }
@@ skipping 143 matching lines @@
   for (HeaderVector::const_iterator it = headers_.begin();
        it != headers_.end(); ++it) {
     if (base::EqualsCaseInsensitiveASCII(key, it->key))
       return it;
   }
 
   return headers_.end();
 }
 
 }  // namespace net