Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1374863002: Reland of DevTools: extract V8DebuggerAgent interface, move it under .../inspector/v8 (Closed)

Created:
5 years, 2 months ago by yurys
Modified:
5 years, 2 months ago
CC:
chromium-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org, oilpan-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of DevTools: extract V8DebuggerAgent interface, move it under .../inspector/v8 (patchset #1 id:1 of https://codereview.chromium.org/1370373004/ ) Reason for revert: The patch did not break main bots and should not have been reverted. Original issue's description: > Revert of DevTools: extract V8DebuggerAgent interface, move it under .../inspector/v8 (patchset #5 id:80001 of https://codereview.chromium.org/1367623006/ ) > > Reason for revert: > Broke oilpan: > > In file included from gen/blink/core/InspectorInstrumentationImpl.cpp:10: > ../../third_party/WebKit/Source/core/inspector/AsyncCallTracker.h:58:5: error: only virtual member functions can be marked 'override' > WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(AsyncCallTracker); > ^ > ../../third_party/WebKit/Source/platform/heap/GarbageCollected.h:210:53: note: expanded from macro 'WILL_BE_USING_GARBAGE_COLLECTED_MIXIN' > #define WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(TYPE) USING_GARBAGE_COLLECTED_MIXIN(TYPE) > ^ > ../../third_party/WebKit/Source/platform/heap/GarbageCollected.h:199:5: note: expanded from macro 'USING_GARBAGE_COLLECTED_MIXIN' > DEFINE_GARBAGE_COLLECTED_MIXIN_METHODS(blink::Visitor*, TYPE) \ > ^ > ../../third_party/WebKit/Source/platform/heap/GarbageCollected.h:134:47: note: expanded from macro 'DEFINE_GARBAGE_COLLECTED_MIXIN_METHODS' > void adjustAndMark(VISITOR visitor) const override > > Original issue's description: > > DevTools: extract V8DebuggerAgent interface, move it under .../inspector/v8 > > > > V8DebuggerAgent was split into interface and implementation. All other agents should depend on the public part only. > > > > Once InjectedScript, InjectedScriptHost and InjectedScriptManager are also moved to .../inspector/v8 some of the methods on V8DebuggerAgent will be removed and called only by the implementation classes. > > > > BUG=439376 > > > > Committed: https://crrev.com/80862359ba867d2807e9ba7b366b352ee5cfda2b > > Cr-Commit-Position: refs/heads/master@{#351166} > > TBR=dgozman@chromium.org,pfeldman@chromium.org,yurys@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=439376 > > Committed: https://crrev.com/3ef449bafc04114479f0e6a17ffdbc9fe7419b27 > Cr-Commit-Position: refs/heads/master@{#351228} TBR=dgozman@chromium.org,pfeldman@chromium.org,haraken@chromium.org,thestig@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=439376 Committed: https://crrev.com/0a732f39b49fe5f3a2f6e15833bea85c3b5f68ab Cr-Commit-Position: refs/heads/master@{#351269}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2298 lines, -2206 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/AsyncCallTracker.h View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/AsyncCallTracker.cpp View 3 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/AsyncOperationMap.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InjectedScriptHost.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.h View 3 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp View 5 chunks +14 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/inspector/V8AsyncCallTracker.h View 1 chunk +0 lines, -54 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/V8AsyncCallTracker.cpp View 1 chunk +0 lines, -143 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/V8DebuggerAgent.h View 1 chunk +0 lines, -276 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/V8DebuggerAgent.cpp View 1 chunk +0 lines, -1702 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/core/inspector/v8/V8AsyncCallTracker.h View 1 chunk +53 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/inspector/v8/V8AsyncCallTracker.cpp View 1 chunk +138 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgent.h View 1 chunk +130 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h View 1 chunk +248 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp View 1 chunk +1695 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yurys
Created Reland of DevTools: extract V8DebuggerAgent interface, move it under .../inspector/v8
5 years, 2 months ago (2015-09-29 08:26:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374863002/1
5 years, 2 months ago (2015-09-29 08:27:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-29 08:29:00 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0a732f39b49fe5f3a2f6e15833bea85c3b5f68ab Cr-Commit-Position: refs/heads/master@{#351269}
5 years, 2 months ago (2015-09-29 08:29:55 UTC) #4
haraken
5 years, 2 months ago (2015-09-29 08:36:38 UTC) #5
Message was sent while issue was closed.
LGTM, but you should have fixed the breakage since you know the CL breaks the
oilpan bot...

Powered by Google App Engine
This is Rietveld 408576698