chrome/browser/ui/views/frame/browser_view.cc - Issue 137483007: [DevTools] Use special resizing strategy instead of insets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 137483007: [DevTools] Use special resizing strategy instead of insets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/devtools/devtools_embedder_message_dispatcher.cc ('K') | « chrome/browser/ui/cocoa/dev_tools_controller.mm ('k') | chrome/browser/ui/views/frame/contents_layout_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index 935838d138949d3de9949c569328982611f1ab68..d5d008e597468727739a447e5e1e851ac6aae9bf 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -2137,11 +2137,12 @@ void BrowserView::UpdateDevToolsForContents(

if (devtools_window_) {

devtools_web_view_->SetPreferredSize(devtools_window_->GetMinimumSize());

devtools_web_view_->SetVisible(true);

- GetContentsLayoutManager()->SetContentsViewInsets(

- devtools_window_->GetContentsInsets());

+ GetContentsLayoutManager()->SetContentsResizingStrategy(

+ devtools_window_->GetContentsResizingStrategy());

} else {

devtools_web_view_->SetVisible(false);

- GetContentsLayoutManager()->SetContentsViewInsets(gfx::Insets());

+ GetContentsLayoutManager()->SetContentsResizingStrategy(

+ DevToolsContentsResizingStrategy());

}

contents_container_->Layout();

}