Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 137483007: [DevTools] Use special resizing strategy instead of insets. (Closed)

Created:
6 years, 10 months ago by dgozman
Modified:
6 years, 10 months ago
CC:
chromium-reviews, vsevik, tfarina, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[DevTools] Use special resizing strategy instead of insets. This change: - adds minimum contents size to be used in layout logic; - switches to new API methods; - moves layout logic into resizing strategy to avoid code duplication. BUG=339425 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248965

Patch Set 1 #

Patch Set 2 : #

Total comments: 8

Patch Set 3 : #

Patch Set 4 : #

Total comments: 6

Patch Set 5 : Fixed review comments #

Patch Set 6 : #

Total comments: 14

Patch Set 7 : Fixed review comments #

Total comments: 4

Patch Set 8 : Fixed more comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+357 lines, -70 lines) Patch
A chrome/browser/devtools/devtools_contents_resizing_strategy.h View 1 2 3 4 5 6 7 1 chunk +51 lines, -0 lines 0 comments Download
A chrome/browser/devtools/devtools_contents_resizing_strategy.cc View 1 2 3 4 5 6 1 chunk +65 lines, -0 lines 0 comments Download
A chrome/browser/devtools/devtools_contents_resizing_strategy_unittest.cc View 1 2 3 4 5 6 7 1 chunk +102 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_embedder_message_dispatcher.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_embedder_message_dispatcher.cc View 1 2 2 chunks +33 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_window.h View 1 2 3 4 5 6 5 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 2 3 4 5 6 2 chunks +12 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/dev_tools_controller.mm View 1 2 3 4 5 6 4 chunks +24 lines, -24 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.h View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 1 2 3 4 5 6 2 chunks +21 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 4 5 6 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/contents_layout_manager.h View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/frame/contents_layout_manager.cc View 1 2 3 4 5 6 2 chunks +21 lines, -12 lines 0 comments Download
M chrome/chrome.gyp View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/secondary/chrome/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
dgozman
Take a look please.
6 years, 10 months ago (2014-01-30 17:37:52 UTC) #1
pfeldman
https://codereview.chromium.org/137483007/diff/10013/chrome/browser/devtools/devtools_contents_resizing_strategy.cc File chrome/browser/devtools/devtools_contents_resizing_strategy.cc (right): https://codereview.chromium.org/137483007/diff/10013/chrome/browser/devtools/devtools_contents_resizing_strategy.cc#newcode13 chrome/browser/devtools/devtools_contents_resizing_strategy.cc:13: void DevToolsContentsResizingStrategy::Apply( This looks more like a static utility ...
6 years, 10 months ago (2014-01-31 11:28:30 UTC) #2
dgozman
PTAL https://codereview.chromium.org/137483007/diff/10013/chrome/browser/devtools/devtools_contents_resizing_strategy.cc File chrome/browser/devtools/devtools_contents_resizing_strategy.cc (right): https://codereview.chromium.org/137483007/diff/10013/chrome/browser/devtools/devtools_contents_resizing_strategy.cc#newcode13 chrome/browser/devtools/devtools_contents_resizing_strategy.cc:13: void DevToolsContentsResizingStrategy::Apply( On 2014/01/31 11:28:30, pfeldman wrote: > ...
6 years, 10 months ago (2014-01-31 13:33:13 UTC) #3
pfeldman
lgtm https://codereview.chromium.org/137483007/diff/40001/chrome/browser/devtools/devtools_contents_resizing_strategy.h File chrome/browser/devtools/devtools_contents_resizing_strategy.h (right): https://codereview.chromium.org/137483007/diff/40001/chrome/browser/devtools/devtools_contents_resizing_strategy.h#newcode29 chrome/browser/devtools/devtools_contents_resizing_strategy.h:29: // Insets of contents inside DevTools. Blank line ...
6 years, 10 months ago (2014-01-31 15:08:27 UTC) #4
dgozman
Hello OWNERS, could you please have a look at respective parts? Scott - at views, ...
6 years, 10 months ago (2014-02-01 13:21:35 UTC) #5
Tom Sepez
lgtm
6 years, 10 months ago (2014-02-01 18:54:16 UTC) #6
Nico
cocoa lgtm (ps: Just saw the "make devtools subview of webview" bug – scary!)
6 years, 10 months ago (2014-02-03 19:49:56 UTC) #7
Elliot Glaysher
gtk lgtm
6 years, 10 months ago (2014-02-03 20:04:04 UTC) #8
sky
I wasn't sure what DevToolsContentsResizingStrategy, was so I looked a bit at the implementation and ...
6 years, 10 months ago (2014-02-03 22:17:28 UTC) #9
dgozman
Scott, please take another look. https://codereview.chromium.org/137483007/diff/150001/chrome/browser/devtools/devtools_contents_resizing_strategy.cc File chrome/browser/devtools/devtools_contents_resizing_strategy.cc (right): https://codereview.chromium.org/137483007/diff/150001/chrome/browser/devtools/devtools_contents_resizing_strategy.cc#newcode6 chrome/browser/devtools/devtools_contents_resizing_strategy.cc:6: #include <cstdio> On 2014/02/03 ...
6 years, 10 months ago (2014-02-04 13:08:47 UTC) #10
sky
LGTM https://codereview.chromium.org/137483007/diff/300001/chrome/browser/devtools/devtools_contents_resizing_strategy.h File chrome/browser/devtools/devtools_contents_resizing_strategy.h (right): https://codereview.chromium.org/137483007/diff/300001/chrome/browser/devtools/devtools_contents_resizing_strategy.h#newcode38 chrome/browser/devtools/devtools_contents_resizing_strategy.h:38: void ApplyDevToolsContentsResizingStrategy( Add description. https://codereview.chromium.org/137483007/diff/300001/chrome/browser/devtools/devtools_contents_resizing_strategy_unittest.cc File chrome/browser/devtools/devtools_contents_resizing_strategy_unittest.cc (right): ...
6 years, 10 months ago (2014-02-04 15:12:17 UTC) #11
dgozman
Thank you for review. https://codereview.chromium.org/137483007/diff/300001/chrome/browser/devtools/devtools_contents_resizing_strategy.h File chrome/browser/devtools/devtools_contents_resizing_strategy.h (right): https://codereview.chromium.org/137483007/diff/300001/chrome/browser/devtools/devtools_contents_resizing_strategy.h#newcode38 chrome/browser/devtools/devtools_contents_resizing_strategy.h:38: void ApplyDevToolsContentsResizingStrategy( On 2014/02/04 15:12:17, ...
6 years, 10 months ago (2014-02-04 15:29:00 UTC) #12
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 10 months ago (2014-02-04 16:33:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/137483007/540001
6 years, 10 months ago (2014-02-04 16:35:33 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 17:24:09 UTC) #15
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=223350
6 years, 10 months ago (2014-02-04 17:24:10 UTC) #16
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 10 months ago (2014-02-05 09:58:50 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/137483007/540001
6 years, 10 months ago (2014-02-05 10:01:34 UTC) #18
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 11:19:39 UTC) #19
Message was sent while issue was closed. 
Change committed as 248965

Powered by Google App Engine
This is Rietveld 408576698