Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Issue 1374793002: Don't allow drops of invalid URLs. (Closed)

Created:
5 years, 2 months ago by Avi (use Gerrit)
Modified:
5 years, 2 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't allow drops of invalid URLs. BUG=528228 TEST=none Committed: https://crrev.com/2edf360e776b15161e7f11c07b28f64d2a99d7c7 Cr-Commit-Position: refs/heads/master@{#351115}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Avi (use Gerrit)
5 years, 2 months ago (2015-09-28 18:53:03 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374793002/1
5 years, 2 months ago (2015-09-28 18:57:50 UTC) #4
Charlie Reis
LGTM. Better than navigating to about:blank, which is what we do in 47.0.2521.0 now that ...
5 years, 2 months ago (2015-09-28 19:16:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374793002/1
5 years, 2 months ago (2015-09-28 19:19:14 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 19:32:25 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 19:33:46 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2edf360e776b15161e7f11c07b28f64d2a99d7c7
Cr-Commit-Position: refs/heads/master@{#351115}

Powered by Google App Engine
This is Rietveld 408576698