fix inference of object members on library prefix

fix inference of object members on library prefix
See https://github.com/dart-lang/dev_compiler/issues/349 for context.

The prefix fix handled `toString()` but not `library_prefix.toString()`

R=brianwilkerson@google.com, leafp@google.com

Committed: https://github.com/dart-lang/sdk/commit/253fc292cb78ae4b02c21e3fdad1b44eb3ce8b9a

[Jennifer Messerly, 2015-09-28 20:36:14]

jmesserly@google.com changed reviewers:
+ brianwilkerson@google.com, leafp@google.com

[Jennifer Messerly, 2015-09-28 20:37:27]

BTW, there's yet another issue (with getters), I can roll it into this fix or
start a new CL, up to y'all :)

[Leaf, 2015-09-28 20:44:46]

lgtm

[Brian Wilkerson, 2015-09-28 20:53:19]

LGTM

https://codereview.chromium.org/1374773003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/static_type_analyzer.dart (right):

https://codereview.chromium.org/1374773003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/static_type_analyzer.dart:1767: Expression target
= node.target;
You probably want 'realTarget' so that this works with cascade expressions as
well.

[Jennifer Messerly, 2015-09-28 21:15:47]

Thanks guys! PTAL

https://codereview.chromium.org/1374773003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/static_type_analyzer.dart (right):

https://codereview.chromium.org/1374773003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/static_type_analyzer.dart:1767: Expression target
= node.target;
On 2015/09/28 20:53:19, Brian Wilkerson wrote:
> You probably want 'realTarget' so that this works with cascade expressions as
> well.

Wow, good catch! Added a test.

https://codereview.chromium.org/1374773003/diff/20001/pkg/analyzer/test/gener...
File pkg/analyzer/test/generated/resolver_test.dart (right):

https://codereview.chromium.org/1374773003/diff/20001/pkg/analyzer/test/gener...
pkg/analyzer/test/generated/resolver_test.dart:13909: void
test_objectMethodInference_disabled_for_local_function() {
I noticed these tests seemed to be in the wrong place, so moved them to be near
the other infer-object-member tests.

[Brian Wilkerson, 2015-09-28 21:24:17]

LGTM

https://codereview.chromium.org/1374773003/diff/20001/pkg/analyzer/test/gener...
File pkg/analyzer/test/generated/resolver_test.dart (right):

https://codereview.chromium.org/1374773003/diff/20001/pkg/analyzer/test/gener...
pkg/analyzer/test/generated/resolver_test.dart:13909: void
test_objectMethodInference_disabled_for_local_function() {
That's fine, but just FYI: we always format and sort our files, so these will
probably get moved on the next commit by someone on the team.

[Brian Wilkerson, 2015-09-28 21:24:17]

LGTM

https://codereview.chromium.org/1374773003/diff/20001/pkg/analyzer/test/gener...
File pkg/analyzer/test/generated/resolver_test.dart (right):

https://codereview.chromium.org/1374773003/diff/20001/pkg/analyzer/test/gener...
pkg/analyzer/test/generated/resolver_test.dart:13909: void
test_objectMethodInference_disabled_for_local_function() {
That's fine, but just FYI: we always format and sort our files, so these will
probably get moved on the next commit by someone on the team.

[Jennifer Messerly, 2015-09-28 21:39:44]

https://codereview.chromium.org/1374773003/diff/20001/pkg/analyzer/test/gener...
File pkg/analyzer/test/generated/resolver_test.dart (right):

https://codereview.chromium.org/1374773003/diff/20001/pkg/analyzer/test/gener...
pkg/analyzer/test/generated/resolver_test.dart:13909: void
test_objectMethodInference_disabled_for_local_function() {
On 2015/09/28 21:24:17, Brian Wilkerson wrote:
> That's fine, but just FYI: we always format and sort our files, so these will
> probably get moved on the next commit by someone on the team.

sounds good. I renamed them too (old name was localVariableInference) so it
should end up in a good place!

Let me know how I can help with sorting. Not sure if any of our editor plugins
(e.g. IntelliJ/WebStorm) support that feature?

(I wish dart_style did stuff like that ... ugh =\ )

[Jennifer Messerly, 2015-09-28 21:40:25]

Committed patchset #2 (id:20001) manually as
253fc292cb78ae4b02c21e3fdad1b44eb3ce8b9a (presubmit successful).