Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8845)

Unified Diff: chrome/chrome_browser.gypi

Issue 1374773002: Componentize script to generate UI string overrides mapping. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@get-resources-index
Patch Set: Rebase and fix //components/variations:unit_tests build with gn Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/metrics/variations/ui_string_overrider_unittest.cc ('k') | chrome/chrome_resources.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_browser.gypi
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi
index 927cb1529cd17ceba1d02d7a2db0ec28be3a97c6..2a33bdc88c1a5d062524c93c8842aff158151e9e 100644
--- a/chrome/chrome_browser.gypi
+++ b/chrome/chrome_browser.gypi
@@ -1883,7 +1883,6 @@
'browser/metrics/time_ticks_experiment_win.h',
'browser/metrics/variations/chrome_variations_service_client.cc',
'browser/metrics/variations/chrome_variations_service_client.h',
- 'browser/metrics/variations/generated_resources_map.h',
'browser/metrics/variations/variations_registry_syncer_win.cc',
'browser/metrics/variations/variations_registry_syncer_win.h',
],
@@ -3081,7 +3080,8 @@
'chrome_resources.gyp:chrome_extra_resources',
'chrome_resources.gyp:chrome_resources',
'chrome_resources.gyp:chrome_strings',
- 'chrome_resources.gyp:chrome_strings_map',
+ 'chrome_resources.gyp:chrome_ui_string_overrider_factory',
+ 'chrome_resources.gyp:make_chrome_ui_string_overrider_factory',
'chrome_resources.gyp:platform_locale_settings',
'chrome_resources.gyp:theme_resources',
'common',
@@ -3307,10 +3307,6 @@
'<(grit_out_dir)/grit/component_extension_resources_map.cc',
'<(grit_out_dir)/grit/settings_resources_map.cc',
'<(grit_out_dir)/grit/theme_resources_map.cc',
-
- # This file is generated by
- # chrome/browser/metrics/variations/generate_resources_map.py
- '<(SHARED_INTERMEDIATE_DIR)/chrome/browser/metrics/variations/generated_resources_map.cc',
],
'conditions': [
['toolkit_views==1', {
« no previous file with comments | « chrome/browser/metrics/variations/ui_string_overrider_unittest.cc ('k') | chrome/chrome_resources.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698