Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Unified Diff: chrome/browser/metrics/variations/ui_string_overrider_unittest.cc

Issue 1374773002: Componentize script to generate UI string overrides mapping. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@get-resources-index
Patch Set: Rebase and fix //components/variations:unit_tests build with gn Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/metrics/variations/generated_resources_map.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/variations/ui_string_overrider_unittest.cc
diff --git a/chrome/browser/metrics/variations/ui_string_overrider_unittest.cc b/chrome/browser/metrics/variations/ui_string_overrider_unittest.cc
deleted file mode 100644
index 5aace0e142f84d6cfabb73d88fb62399c9255e08..0000000000000000000000000000000000000000
--- a/chrome/browser/metrics/variations/ui_string_overrider_unittest.cc
+++ /dev/null
@@ -1,45 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "components/variations/service/ui_string_overrider.h"
-
-#include "chrome/browser/metrics/variations/generated_resources_map.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-// TODO(sdefresne): componentize this tests as part of the resolution
-// of http://crbug.com/534257 ("Decouple iOS port from using //chrome's
-// VariationsService client").
-
-namespace chrome_variations {
-
-class UIStringOverriderTest : public ::testing::Test {
- public:
- UIStringOverriderTest()
- : provider_(kResourceHashes, kResourceIndices, kNumResources) {}
-
- int GetResourceIndex(uint32_t hash) {
- return provider_.GetResourceIndex(hash);
- }
-
- private:
- variations::UIStringOverrider provider_;
-
- DISALLOW_COPY_AND_ASSIGN(UIStringOverriderTest);
-};
-
-TEST_F(UIStringOverriderTest, LookupNotFound) {
- EXPECT_EQ(-1, GetResourceIndex(0));
- EXPECT_EQ(-1, GetResourceIndex(kResourceHashes[kNumResources - 1] + 1));
-
- // Lookup a hash that shouldn't exist.
- // 13257681U is 1 + the hash for IDS_ZOOM_NORMAL
- EXPECT_EQ(-1, GetResourceIndex(13257681U));
-}
-
-TEST_F(UIStringOverriderTest, LookupFound) {
- for (size_t i = 0; i < kNumResources; ++i)
- EXPECT_EQ(kResourceIndices[i], GetResourceIndex(kResourceHashes[i]));
-}
-
-} // namespace chrome_variations
« no previous file with comments | « chrome/browser/metrics/variations/generated_resources_map.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698