Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3777)

Unified Diff: chrome/browser/metrics/variations/generate_resources_map_unittest.py

Issue 1374773002: Componentize script to generate UI string overrides mapping. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@get-resources-index
Patch Set: Rebase and fix //components/variations:unit_tests build with gn Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/variations/generate_resources_map_unittest.py
diff --git a/chrome/browser/metrics/variations/generate_resources_map_unittest.py b/chrome/browser/metrics/variations/generate_resources_map_unittest.py
deleted file mode 100755
index a7b1a2ba2916f16af3ff7840ea347ebe3c41debe..0000000000000000000000000000000000000000
--- a/chrome/browser/metrics/variations/generate_resources_map_unittest.py
+++ /dev/null
@@ -1,93 +0,0 @@
-#!/usr/bin/python
-# Copyright 2014 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-"""Unittests for generate_resources_map.py"""
-
-import unittest
-
-import generate_resources_map
-
-
-class GenerateResourcesMapUnittest(unittest.TestCase):
- TEST_INPUT = """
-// This file is automatically generated by GRIT. Do not edit.
-
-#pragma once
-
-#define IDS_BOOKMARKS_NO_ITEMS 12500
-#define IDS_BOOKMARK_BAR_IMPORT_LINK 12501
-#define IDS_BOOKMARK_GROUP_FROM_IE 12502
-#define IDS_BOOKMARK_GROUP_FROM_FIREFOX 12503
-"""
-
- def testGetResourceListFromString(self):
- expected_tuples = [(301430091, "IDS_BOOKMARKS_NO_ITEMS", "12500"),
- (2654138887, "IDS_BOOKMARK_BAR_IMPORT_LINK", "12501"),
- (2894469061, "IDS_BOOKMARK_GROUP_FROM_IE", "12502"),
- (3847176170, "IDS_BOOKMARK_GROUP_FROM_FIREFOX", "12503")]
- expected = [generate_resources_map.Resource(*t) for t in expected_tuples]
-
- actual_tuples = generate_resources_map._GetResourceListFromString(
- self.TEST_INPUT)
-
- self.assertEqual(expected_tuples, actual_tuples)
-
-
- def testCheckForHashCollisions(self):
- collisions_tuples = [(123, "IDS_FOO", "12500"),
- (456, "IDS_BAR", "12501"),
- (456, "IDS_BAZ", "12502"),
- (890, "IDS_QUX", "12503"),
- (899, "IDS_NO", "12504"),
- (899, "IDS_YES", "12505")]
- list_with_collisions = [generate_resources_map.Resource(*t)
- for t in collisions_tuples]
-
- expected_collision_tuples = [(456, "IDS_BAR", "12501"),
- (456, "IDS_BAZ", "12502"),
- (899, "IDS_NO", "12504"),
- (899, "IDS_YES", "12505")]
- expected_collisions = [generate_resources_map.Resource(*t)
- for t in expected_collision_tuples]
-
- actual_collisions = sorted(
- generate_resources_map._CheckForHashCollisions(list_with_collisions))
- actual_collisions
-
- self.assertEqual(expected_collisions, actual_collisions)
-
- def testGenerateFileContent(self):
- expected = (
- """// This file was generated by generate_resources_map.py. Do not edit.
-
-
-#include "chrome/browser/metrics/variations/generated_resources_map.h"
-
-namespace chrome_variations {
-
-const size_t kNumResources = 4;
-
-const uint32_t kResourceHashes[] = {
- 301430091U, // IDS_BOOKMARKS_NO_ITEMS
- 2654138887U, // IDS_BOOKMARK_BAR_IMPORT_LINK
- 2894469061U, // IDS_BOOKMARK_GROUP_FROM_IE
- 3847176170U, // IDS_BOOKMARK_GROUP_FROM_FIREFOX
-};
-
-const int kResourceIndices[] = {
- 12500, // IDS_BOOKMARKS_NO_ITEMS
- 12501, // IDS_BOOKMARK_BAR_IMPORT_LINK
- 12502, // IDS_BOOKMARK_GROUP_FROM_IE
- 12503, // IDS_BOOKMARK_GROUP_FROM_FIREFOX
-};
-
-} // namespace chrome_variations
-""")
- actual = generate_resources_map._GenerateFileContent(self.TEST_INPUT)
-
- self.assertEqual(expected, actual)
-
-if __name__ == '__main__':
- unittest.main()

Powered by Google App Engine
This is Rietveld 408576698