chrome/chrome_browser.gypi - Issue 1374773002: Componentize script to generate UI string overrides mapping.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 1374773002: Componentize script to generate UI string overrides mapping. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@get-resources-index

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/variations/generated_resources_map.h ('K') | « chrome/browser/metrics/variations/ui_string_overrider_unittest.cc ('k') | chrome/chrome_resources.gyp » ('j') | components/variations/service/generate_ui_string_overrider.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index 654b6e2b2e1539b5e755f17e0a291efef111031c..faadb2408f5a83d5c344d29b496c7f3bc121e077 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -1885,7 +1885,6 @@

'browser/metrics/time_ticks_experiment_win.h',

'browser/metrics/variations/chrome_variations_service_client.cc',

'browser/metrics/variations/chrome_variations_service_client.h',

- 'browser/metrics/variations/generated_resources_map.h',

'browser/metrics/variations/variations_registry_syncer_win.cc',

'browser/metrics/variations/variations_registry_syncer_win.h',

@@ -3081,7 +3080,8 @@

'chrome_resources.gyp:chrome_extra_resources',

'chrome_resources.gyp:chrome_resources',

'chrome_resources.gyp:chrome_strings',

- 'chrome_resources.gyp:chrome_strings_map',

+ 'chrome_resources.gyp:chrome_ui_string_overrider_factory',

+ 'chrome_resources.gyp:make_chrome_ui_string_overrider_factory',

'chrome_resources.gyp:platform_locale_settings',

'chrome_resources.gyp:theme_resources',

'common',

@@ -3307,10 +3307,6 @@

'<(grit_out_dir)/grit/component_extension_resources_map.cc',

'<(grit_out_dir)/grit/settings_resources_map.cc',

'<(grit_out_dir)/grit/theme_resources_map.cc',

- # This file is generated by

- # chrome/browser/metrics/variations/generate_resources_map.py

- '<(SHARED_INTERMEDIATE_DIR)/chrome/browser/metrics/variations/generated_resources_map.cc',

'conditions': [

['toolkit_views==1', {