Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1374733006: [swarming] Run unittests together with default tests. (Closed)

Created:
5 years, 2 months ago by Michael Achenbach
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[swarming] Run unittests together with default tests. This adds the unittests to the "default" test set. Now that the "default" and the DEFAULT_TESTS (i.e. runner with no arguments) are the same, removed DEFAULT_TESTS and use TEST_MAP["default"] instead. On the bots, where unittests and default were run in separation before, the explicit unittests step should now be skipped. This is necessary for swarming, as the unittests step is too small to justify its own swarming job. BUG=chromium:535160 LOG=n Committed: https://crrev.com/35d2028d10668e69c1a71fb17b65eabbf2254982 Cr-Commit-Position: refs/heads/master@{#31122}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -55 lines) Patch
M build/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/default.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/default.isolate View 1 chunk +2 lines, -1 line 0 comments Download
D test/developer_default.gyp View 1 chunk +0 lines, -27 lines 0 comments Download
D test/developer_default.isolate View 1 chunk +0 lines, -9 lines 0 comments Download
M tools/run-tests.py View 6 chunks +10 lines, -17 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374733006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374733006/1
5 years, 2 months ago (2015-10-06 08:31:56 UTC) #2
Michael Achenbach
PTAL
5 years, 2 months ago (2015-10-06 08:37:25 UTC) #4
Benedikt Meurer
LGTM (rubber-stamped)
5 years, 2 months ago (2015-10-06 08:38:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374733006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374733006/1
5 years, 2 months ago (2015-10-06 09:04:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-06 09:31:41 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/35d2028d10668e69c1a71fb17b65eabbf2254982 Cr-Commit-Position: refs/heads/master@{#31122}
5 years, 2 months ago (2015-10-06 09:31:57 UTC) #10
kjellander_chromium
5 years, 2 months ago (2015-10-06 10:07:24 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698