Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: fpdfsdk/include/javascript/JS_Object.h

Issue 1374723004: Remove pointless CPDFSDK_PageView usage in CJS_Object / CJS_EmbedObj. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | fpdfsdk/src/javascript/JS_Object.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/include/javascript/JS_Object.h
diff --git a/fpdfsdk/include/javascript/JS_Object.h b/fpdfsdk/include/javascript/JS_Object.h
index 337da7ba203fc3b499dd4c245a882a8dbd4a3adb..6116a83d17cf346ff7da0499fc43310784a83dd9 100644
--- a/fpdfsdk/include/javascript/JS_Object.h
+++ b/fpdfsdk/include/javascript/JS_Object.h
@@ -17,7 +17,6 @@
#include "../jsapi/fxjs_v8.h"
#include "JS_Runtime.h"
-class CPDFSDK_PageView;
class CJS_Context;
class CJS_Object;
class CJS_Timer;
@@ -31,13 +30,11 @@ class CJS_EmbedObj {
CJS_Object* GetJSObject() const { return m_pJSObject; }
- CPDFSDK_PageView* JSGetPageView(IFXJS_Context* cc);
int MsgBox(CPDFDoc_Environment* pApp,
- CPDFSDK_PageView* pPageView,
const FX_WCHAR* swMsg,
- const FX_WCHAR* swTitle = NULL,
- FX_UINT nType = 0,
- FX_UINT nIcon = 0);
+ const FX_WCHAR* swTitle,
+ FX_UINT nType,
+ FX_UINT nIcon);
void Alert(CJS_Context* pContext, const FX_WCHAR* swMsg);
protected:
@@ -64,13 +61,11 @@ class CJS_Object {
void SetEmbedObject(CJS_EmbedObj* pObj) { m_pEmbedObj.reset(pObj); }
CJS_EmbedObj* GetEmbedObject() const { return m_pEmbedObj.get(); }
- static CPDFSDK_PageView* JSGetPageView(IFXJS_Context* cc);
static int MsgBox(CPDFDoc_Environment* pApp,
- CPDFSDK_PageView* pPageView,
const FX_WCHAR* swMsg,
- const FX_WCHAR* swTitle = NULL,
- FX_UINT nType = 0,
- FX_UINT nIcon = 0);
+ const FX_WCHAR* swTitle,
+ FX_UINT nType,
+ FX_UINT nIcon);
static void Alert(CJS_Context* pContext, const FX_WCHAR* swMsg);
v8::Isolate* GetIsolate() { return m_pIsolate; }
« no previous file with comments | « no previous file | fpdfsdk/src/javascript/JS_Object.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698