src/full-codegen/x64/full-codegen-x64.cc - Issue 1374723002: Introduce LiteralsArray to hide it's implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/x64/full-codegen-x64.cc

Issue 1374723002: Introduce LiteralsArray to hide it's implementation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: More comments. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/x64/full-codegen-x64.cc

diff --git a/src/full-codegen/x64/full-codegen-x64.cc b/src/full-codegen/x64/full-codegen-x64.cc

index 553e6270386cc003873f54530d11794e2def1587..64c05125c0c5fec7f9c99568fd0337caa9c533cb 100644

--- a/src/full-codegen/x64/full-codegen-x64.cc

+++ b/src/full-codegen/x64/full-codegen-x64.cc

@@ -1453,8 +1453,7 @@ void FullCodeGenerator::VisitRegExpLiteral(RegExpLiteral* expr) {

// rax = regexp literal clone.

__ movp(rdi, Operand(rbp, JavaScriptFrameConstants::kFunctionOffset));

__ movp(rcx, FieldOperand(rdi, JSFunction::kLiteralsOffset));

- int literal_offset =

- FixedArray::kHeaderSize + expr->literal_index() * kPointerSize;

+ int literal_offset = LiteralsArray::OffsetOfLiteralAt(expr->literal_index());

__ movp(rbx, FieldOperand(rcx, literal_offset));

__ CompareRoot(rbx, Heap::kUndefinedValueRootIndex);

__ j(not_equal, &materialized, Label::kNear);