src/full-codegen/arm/full-codegen-arm.cc - Issue 1374723002: Introduce LiteralsArray to hide it's implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 1374723002: Introduce LiteralsArray to hide it's implementation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: More comments. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/arm/full-codegen-arm.cc

diff --git a/src/full-codegen/arm/full-codegen-arm.cc b/src/full-codegen/arm/full-codegen-arm.cc

index ec4d6d4681e2225a7067bdc68957807e726062c0..3391f2debd35c88bd98d8867228a161793f9bba7 100644

--- a/src/full-codegen/arm/full-codegen-arm.cc

+++ b/src/full-codegen/arm/full-codegen-arm.cc

@@ -1498,8 +1498,7 @@ void FullCodeGenerator::VisitRegExpLiteral(RegExpLiteral* expr) {

// r0 = RegExp literal clone

__ ldr(r0, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));

__ ldr(r4, FieldMemOperand(r0, JSFunction::kLiteralsOffset));

- int literal_offset =

- FixedArray::kHeaderSize + expr->literal_index() * kPointerSize;

+ int literal_offset = LiteralsArray::OffsetOfLiteralAt(expr->literal_index());

__ ldr(r5, FieldMemOperand(r4, literal_offset));

__ LoadRoot(ip, Heap::kUndefinedValueRootIndex);

__ cmp(r5, ip);