src/full-codegen/ia32/full-codegen-ia32.cc - Issue 1374723002: Introduce LiteralsArray to hide it's implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 1374723002: Introduce LiteralsArray to hide it's implementation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comments. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/ia32/full-codegen-ia32.cc

diff --git a/src/full-codegen/ia32/full-codegen-ia32.cc b/src/full-codegen/ia32/full-codegen-ia32.cc

index 50d84d06cf7971b020a9e77ecad2e0a5becab661..4fdb0e1bdc9a2299d0e386bc86a703c5917d6202 100644

--- a/src/full-codegen/ia32/full-codegen-ia32.cc

+++ b/src/full-codegen/ia32/full-codegen-ia32.cc

@@ -1422,8 +1422,7 @@ void FullCodeGenerator::VisitRegExpLiteral(RegExpLiteral* expr) {

// eax = regexp literal clone.

__ mov(edi, Operand(ebp, JavaScriptFrameConstants::kFunctionOffset));

__ mov(ecx, FieldOperand(edi, JSFunction::kLiteralsOffset));

- int literal_offset =

- FixedArray::kHeaderSize + expr->literal_index() * kPointerSize;

+ int literal_offset = LiteralsArray::OffsetOfLiteralAt(expr->literal_index());

__ mov(ebx, FieldOperand(ecx, literal_offset));

__ cmp(ebx, isolate()->factory()->undefined_value());

__ j(not_equal, &materialized, Label::kNear);