src/arm64/lithium-codegen-arm64.cc - Issue 1374723002: Introduce LiteralsArray to hide it's implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm64/lithium-codegen-arm64.cc

Issue 1374723002: Introduce LiteralsArray to hide it's implementation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comments. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm64/lithium-codegen-arm64.cc

diff --git a/src/arm64/lithium-codegen-arm64.cc b/src/arm64/lithium-codegen-arm64.cc

index 11e99b03c9903cf8d8bcd6acb3e985fe61487af0..76d7e598e3a25f9934dc7db2cbd2cc0f969829b4 100644

--- a/src/arm64/lithium-codegen-arm64.cc

+++ b/src/arm64/lithium-codegen-arm64.cc

@@ -5648,7 +5648,7 @@ void LCodeGen::DoRegExpLiteral(LRegExpLiteral* instr) {

// x0 = regexp literal clone.

// x10-x12 are used as temporaries.

int literal_offset =

- FixedArray::OffsetOfElementAt(instr->hydrogen()->literal_index());

+ LiteralsArray::OffsetOfLiteralAt(instr->hydrogen()->literal_index());

__ LoadObject(x7, instr->hydrogen()->literals());

__ Ldr(x1, FieldMemOperand(x7, literal_offset));

__ JumpIfNotRoot(x1, Heap::kUndefinedValueRootIndex, &materialized);