Chromium Code Reviews

Unified Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 1374723002: Introduce LiteralsArray to hide it's implementation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Ports done. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: src/full-codegen/arm/full-codegen-arm.cc
diff --git a/src/full-codegen/arm/full-codegen-arm.cc b/src/full-codegen/arm/full-codegen-arm.cc
index ec4d6d4681e2225a7067bdc68957807e726062c0..ce4c07c340c09164ba0f0cbcb1ee8afaa73044a4 100644
--- a/src/full-codegen/arm/full-codegen-arm.cc
+++ b/src/full-codegen/arm/full-codegen-arm.cc
@@ -1498,8 +1498,8 @@ void FullCodeGenerator::VisitRegExpLiteral(RegExpLiteral* expr) {
// r0 = RegExp literal clone
__ ldr(r0, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));
__ ldr(r4, FieldMemOperand(r0, JSFunction::kLiteralsOffset));
- int literal_offset =
- FixedArray::kHeaderSize + expr->literal_index() * kPointerSize;
+ int literal_offset = LiteralsArray::kOffsetToFirstLiteral +
Igor Sheludko 2015/09/28 15:16:45 LiteralsArray::OffsetOfLiteralAt()?
mvstanton 2015/09/28 16:01:33 Done.
+ expr->literal_index() * kPointerSize;
__ ldr(r5, FieldMemOperand(r4, literal_offset));
__ LoadRoot(ip, Heap::kUndefinedValueRootIndex);
__ cmp(r5, ip);

Powered by Google App Engine