Introduce LiteralsArray to hide it's implementation.

src/arm/lithium-codegen-arm.cc

Index: src/arm/lithium-codegen-arm.cc
diff --git a/src/arm/lithium-codegen-arm.cc b/src/arm/lithium-codegen-arm.cc
index b163061458ec1376cfd4623c957df2138a0df90c..3c22ae3a6df17ce17107dbcf8179cfd51f7bc7dd 100644
--- a/src/arm/lithium-codegen-arm.cc
+++ b/src/arm/lithium-codegen-arm.cc
@@ -5397,8 +5397,8 @@ void LCodeGen::DoRegExpLiteral(LRegExpLiteral* instr) {
   // r1 = regexp literal.
   // r0 = regexp literal clone.
   // r2-5 are used as temporaries.
-  int literal_offset =
-      FixedArray::OffsetOfElementAt(instr->hydrogen()->literal_index());
+  int literal_offset = LiteralsArray::OffsetOfElementAt(
+      instr->hydrogen()->literal_index() + LiteralsArray::kFirstLiteralIndex);

[Igor Sheludko, 2015/09/28 15:16:45]

Shouldn't " + LiteralsArray::kFirstLiteralIndex" be done inside the method?
WDYT about introducing LiteralsArray::OffsetOfLiteralAt()?

[mvstanton, 2015/09/28 16:01:33]

I'd like all places that talk about a literal index mean the literal index as
assigned as AST time. These are 0, 1, .... 

It's only at the last moment in stubs or direct looks at the array that the
index is resolved to a FixedArray index.

I'll use OffsetOfLiteralAt here, good idea.

   __ Move(r6, instr->hydrogen()->literals());
   __ ldr(r1, FieldMemOperand(r6, literal_offset));
   __ LoadRoot(ip, Heap::kUndefinedValueRootIndex);