Issue 13747002: Call the correct superclass in RenderSlider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13747002: Call the correct superclass in RenderSlider (Closed)

Created:
7 years, 8 months ago by cbiesinger

Modified:
7 years, 8 months ago

Reviewers:
eseidel, ojan

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Call the correct superclass in RenderSlider The superclass is RenderFlexibleBox, not RenderBlock. No visual change. R=ojan@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=147850

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/WebCore/rendering/RenderSlider.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (0 generated)

ojan

lgtm On 2013/04/06 03:47:55, Eric Seidel (Google) wrote: > So you do not believe this ...

7 years, 8 months ago (2013-04-06 18:37:08 UTC) #4

cbiesinger

On 2013/04/06 03:48:04, Eric Seidel (Google) wrote: > at least not observably. :) Yes - ...

7 years, 8 months ago (2013-04-08 20:42:01 UTC) #5

cbiesinger

7 years, 8 months ago (2013-04-08 20:43:15 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 manually as r147850 (presubmit successful).