Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: src/compiler/js-generic-lowering.cc

Issue 1374683002: [turbofan] Make Strict(Not)Equal, TypeOf, ToBoolean, UnaryNot effectful. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler/js-operator.cc » ('j') | src/compiler/js-operator.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/js-generic-lowering.cc
diff --git a/src/compiler/js-generic-lowering.cc b/src/compiler/js-generic-lowering.cc
index 4937b1dea37f3b3db16049fb57eecb4a6f19a602..7eb5bd920ed9893fffc7ca7861a21990877f3ee4 100644
--- a/src/compiler/js-generic-lowering.cc
+++ b/src/compiler/js-generic-lowering.cc
@@ -155,6 +155,11 @@ void JSGenericLowering::ReplaceWithCompareIC(Node* node, Token::Value token,
DCHECK(OperatorProperties::GetFrameStateInputCount(node->op()) == 0);
inputs.push_back(graph()->start());
inputs.push_back(graph()->start());
+ } else if (node->op()->HasProperty(Operator::kEliminatable)) {
+ DCHECK(OperatorProperties::GetFrameStateInputCount(node->op()) == 0);
+ DCHECK(node->op()->ControlInputCount() == 0);
+ inputs.push_back(NodeProperties::GetEffectInput(node));
+ inputs.push_back(graph()->start());
} else {
inputs.push_back(NodeProperties::GetFrameStateInput(node, 0));
inputs.push_back(NodeProperties::GetEffectInput(node));
« no previous file with comments | « no previous file | src/compiler/js-operator.cc » ('j') | src/compiler/js-operator.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698