[turbofan] Make Strict(Not)Equal, TypeOf, ToBoolean, UnaryNot effectful.

[turbofan] Make Strict(Not)Equal, TypeOf, ToBoolean, UnaryNot effectful.

This is necessary because these operators can read heap (equality can actually write heap when flattening strings).

BUG=v8:4446
LOG=n

Committed: https://crrev.com/d06930fc4b19a759972950e81d55eb93d9a572c0
Cr-Commit-Position: refs/heads/master@{#31005}

[Jarin, 2015-09-28 10:53:17]

jarin@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Jarin, 2015-09-28 10:53:55]

Could you take a look, please?

[Benedikt Meurer, 2015-09-28 11:42:48]

https://codereview.chromium.org/1374683002/diff/1/src/compiler/js-operator.cc
File src/compiler/js-operator.cc (right):

https://codereview.chromium.org/1374683002/diff/1/src/compiler/js-operator.cc...
src/compiler/js-operator.cc:457: V(StrictEqual, Operator::kEliminatable, 2, 1)  
        \
kNoWrite is wrong here, since StringEqual and friends do write memory.

[Jarin, 2015-09-28 12:05:34]

https://codereview.chromium.org/1374683002/diff/1/src/compiler/js-operator.cc
File src/compiler/js-operator.cc (right):

https://codereview.chromium.org/1374683002/diff/1/src/compiler/js-operator.cc...
src/compiler/js-operator.cc:457: V(StrictEqual, Operator::kEliminatable, 2, 1)  
        \
On 2015/09/28 11:42:48, Benedikt Meurer wrote:
> kNoWrite is wrong here, since StringEqual and friends do write memory.

Done.

[Benedikt Meurer, 2015-09-28 14:21:06]

Please add a better explanation to the CL description (and maybe even a tracking
bug for this).

Otherwise LGTM

[Jarin, 2015-09-29 13:28:03]

The CQ bit was checked by jarin@chromium.org

[commit-bot: I haz the power, 2015-09-29 13:28:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1374683002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1374683002/20001

[commit-bot: I haz the power, 2015-09-29 13:51:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-29 13:51:45]

Patchset 2 (id:??) landed as
https://crrev.com/d06930fc4b19a759972950e81d55eb93d9a572c0
Cr-Commit-Position: refs/heads/master@{#31005}