Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1374663002: [bootstrapper] Fix raw pointer use during potential GC. (Closed)

Created:
5 years, 2 months ago by Benedikt Meurer
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[bootstrapper] Fix raw pointer use during potential GC. This should fix a weird random crash we keep seeing on Linux nosnap bot with TurboFan enabled. BUG=v8:4435, v8:4423 LOG=n R=mvstanton@chromium.org Committed: https://crrev.com/8611fb31a273ebcf2f0cb2a36929fe48f52e8fd5 Cr-Commit-Position: refs/heads/master@{#30968}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -19 lines) Patch
M src/bootstrapper.cc View 2 chunks +26 lines, -19 lines 2 comments Download

Messages

Total messages: 12 (4 generated)
Benedikt Meurer
Michael S.: PTAL Michael A.: FYI (we need more Michael's)
5 years, 2 months ago (2015-09-28 09:20:22 UTC) #3
mvstanton
Thanks Benedikt. I have to port this back to 4.6 :p. LGTM.
5 years, 2 months ago (2015-09-28 09:21:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374663002/1
5 years, 2 months ago (2015-09-28 09:39:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 09:42:12 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8611fb31a273ebcf2f0cb2a36929fe48f52e8fd5 Cr-Commit-Position: refs/heads/master@{#30968}
5 years, 2 months ago (2015-09-28 09:42:32 UTC) #8
Michael Starzinger
https://codereview.chromium.org/1374663002/diff/1/src/bootstrapper.cc File src/bootstrapper.cc (left): https://codereview.chromium.org/1374663002/diff/1/src/bootstrapper.cc#oldcode1812 src/bootstrapper.cc:1812: *TypeFeedbackVector::CreatePushAppliedArgumentsVector(isolate)); Holy sh*t, GCMole didn't find this, that is ...
5 years, 2 months ago (2015-10-01 17:37:48 UTC) #9
Benedikt Meurer
https://codereview.chromium.org/1374663002/diff/1/src/bootstrapper.cc File src/bootstrapper.cc (left): https://codereview.chromium.org/1374663002/diff/1/src/bootstrapper.cc#oldcode1812 src/bootstrapper.cc:1812: *TypeFeedbackVector::CreatePushAppliedArgumentsVector(isolate)); On 2015/10/01 17:37:48, Michael Starzinger wrote: > Holy ...
5 years, 2 months ago (2015-10-01 17:52:23 UTC) #10
Michael Achenbach
5 years, 2 months ago (2015-10-01 19:07:19 UTC) #12
Message was sent while issue was closed.
FYI: Michael H. for porting back :)

Powered by Google App Engine
This is Rietveld 408576698