Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1374653003: scheduler: Add a base directory (Closed)

Created:
5 years, 2 months ago by Sami
Modified:
5 years, 2 months ago
CC:
blundell+watchlist_chromium.org, chromium-reviews, droger+watchlist_chromium.org, scheduler-bugs_chromium.org, sdefresne+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

scheduler: Add a base directory This patch moves the more fundamental scheduling primitives (e.g., TaskQueueManager) to a separate base/ directory. This makes the layered architecture of the scheduler more obvious and reduces the likelihood of accidentally introducing layering violations. With this refactoring, the overall dependencies are: +------+ | base | +------+ ^ | +-------+ +------+ | child |<----| test | +-------+ +------+ ^ ^ ^ ^ | | | | | '----------|-|---. | .----------' '-. | | | | | +----------+ +-------+ | renderer | | ppapi | +----------+ +-------+ Committed: https://crrev.com/516bee16e9437521cdd20a78d683f9dbaf35df3e Cr-Commit-Position: refs/heads/master@{#351109} Committed: https://crrev.com/0bbc9d23397f6c353186e86f34220f3f13e982b5 Cr-Commit-Position: refs/heads/master@{#351299}

Patch Set 1 #

Patch Set 2 : Linking fix. #

Patch Set 3 : Smaller similarity threshold. #

Patch Set 4 : Missed one header guard. #

Patch Set 5 : Fixed gn clobber build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -4573 lines) Patch
M components/BUILD.gn View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M components/components_tests.gyp View 1 2 3 4 3 chunks +12 lines, -10 lines 0 comments Download
M components/scheduler/BUILD.gn View 2 chunks +9 lines, -9 lines 0 comments Download
A + components/scheduler/base/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
A + components/scheduler/base/cancelable_closure_holder.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/scheduler/base/cancelable_closure_holder.cc View 1 chunk +3 lines, -5 lines 0 comments Download
A + components/scheduler/base/lazy_now.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/scheduler/base/lazy_now.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/scheduler/base/nestable_single_thread_task_runner.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + components/scheduler/base/nestable_task_runner_for_test.h View 2 chunks +5 lines, -7 lines 0 comments Download
A + components/scheduler/base/nestable_task_runner_for_test.cc View 2 chunks +3 lines, -5 lines 0 comments Download
A + components/scheduler/base/pollable_thread_safe_flag.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/scheduler/base/pollable_thread_safe_flag.cc View 1 chunk +3 lines, -5 lines 0 comments Download
A + components/scheduler/base/task_queue.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/scheduler/base/task_queue.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/scheduler/base/task_queue_impl.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + components/scheduler/base/task_queue_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/scheduler/base/task_queue_manager.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + components/scheduler/base/task_queue_manager.cc View 3 chunks +9 lines, -9 lines 0 comments Download
A + components/scheduler/base/task_queue_manager_perftest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
A + components/scheduler/base/task_queue_manager_unittest.cc View 6 chunks +30 lines, -15 lines 0 comments Download
A + components/scheduler/base/task_queue_selector.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/scheduler/base/task_queue_selector.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/scheduler/base/task_queue_selector_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + components/scheduler/base/task_queue_sets.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/scheduler/base/task_queue_sets.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/scheduler/base/task_queue_sets_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/scheduler/base/test_always_fail_time_source.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/scheduler/base/test_always_fail_time_source.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/scheduler/base/test_time_source.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/scheduler/base/test_time_source.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M components/scheduler/child/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
D components/scheduler/child/cancelable_closure_holder.h View 1 chunk +0 lines, -39 lines 0 comments Download
D components/scheduler/child/cancelable_closure_holder.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M components/scheduler/child/child_scheduler.h View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/child/idle_helper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/scheduler/child/idle_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/scheduler/child/idle_helper_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
D components/scheduler/child/lazy_now.h View 1 chunk +0 lines, -37 lines 0 comments Download
D components/scheduler/child/lazy_now.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D components/scheduler/child/nestable_single_thread_task_runner.h View 1 chunk +0 lines, -32 lines 0 comments Download
D components/scheduler/child/nestable_task_runner_for_test.h View 1 chunk +0 lines, -42 lines 0 comments Download
D components/scheduler/child/nestable_task_runner_for_test.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D components/scheduler/child/pollable_thread_safe_flag.h View 1 chunk +0 lines, -35 lines 0 comments Download
D components/scheduler/child/pollable_thread_safe_flag.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M components/scheduler/child/scheduler_helper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/scheduler/child/scheduler_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/child/scheduler_helper_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/scheduler/child/scheduler_task_runner_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/child/scheduler_task_runner_delegate_for_test.cc View 1 chunk +1 line, -1 line 0 comments Download
D components/scheduler/child/task_queue.h View 1 chunk +0 lines, -184 lines 0 comments Download
D components/scheduler/child/task_queue.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D components/scheduler/child/task_queue_impl.h View 1 chunk +0 lines, -212 lines 0 comments Download
D components/scheduler/child/task_queue_impl.cc View 1 chunk +0 lines, -504 lines 0 comments Download
D components/scheduler/child/task_queue_manager.h View 1 chunk +0 lines, -261 lines 0 comments Download
D components/scheduler/child/task_queue_manager.cc View 1 chunk +0 lines, -464 lines 0 comments Download
D components/scheduler/child/task_queue_manager_perftest.cc View 1 chunk +0 lines, -141 lines 0 comments Download
D components/scheduler/child/task_queue_manager_unittest.cc View 1 chunk +0 lines, -1294 lines 0 comments Download
D components/scheduler/child/task_queue_selector.h View 1 chunk +0 lines, -100 lines 0 comments Download
D components/scheduler/child/task_queue_selector.cc View 1 chunk +0 lines, -127 lines 0 comments Download
D components/scheduler/child/task_queue_selector_unittest.cc View 1 chunk +0 lines, -283 lines 0 comments Download
D components/scheduler/child/task_queue_sets.h View 1 chunk +0 lines, -75 lines 0 comments Download
D components/scheduler/child/task_queue_sets.cc View 1 chunk +0 lines, -96 lines 0 comments Download
D components/scheduler/child/task_queue_sets_unittest.cc View 1 chunk +0 lines, -239 lines 0 comments Download
D components/scheduler/child/test_time_source.h View 1 chunk +0 lines, -30 lines 0 comments Download
D components/scheduler/child/test_time_source.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M components/scheduler/child/webthread_impl_for_worker_scheduler.h View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/child/webthread_impl_for_worker_scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/child/worker_scheduler_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/child/worker_scheduler_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/ppapi/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/scheduler/ppapi/webthread_impl_for_ppapi.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/renderer/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/scheduler/renderer/deadline_task_runner.h View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/renderer/renderer_scheduler_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/renderer/renderer_scheduler_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/scheduler/renderer/renderer_scheduler_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/renderer/renderer_web_scheduler_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/renderer/task_cost_estimator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/renderer/webthread_impl_for_renderer_scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/scheduler.gypi View 1 2 chunks +16 lines, -16 lines 0 comments Download
M components/scheduler/test/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
D components/scheduler/test/test_always_fail_time_source.h View 1 chunk +0 lines, -25 lines 0 comments Download
D components/scheduler/test/test_always_fail_time_source.cc View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 26 (10 generated)
Sami
5 years, 2 months ago (2015-09-28 13:07:56 UTC) #2
alex clarke (OOO till 29th)
lgtm
5 years, 2 months ago (2015-09-28 13:24:07 UTC) #3
Sami
Thanks, +jochen@ for components/BUILD.gn (and anything in general that seems off about this patch).
5 years, 2 months ago (2015-09-28 14:24:43 UTC) #5
Sami
5 years, 2 months ago (2015-09-28 14:24:51 UTC) #6
jochen (gone - plz use gerrit)
lgtm
5 years, 2 months ago (2015-09-28 15:58:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374653003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374653003/60001
5 years, 2 months ago (2015-09-28 16:02:25 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/74532)
5 years, 2 months ago (2015-09-28 18:06:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374653003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374653003/60001
5 years, 2 months ago (2015-09-28 18:10:45 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-09-28 19:27:59 UTC) #15
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/516bee16e9437521cdd20a78d683f9dbaf35df3e Cr-Commit-Position: refs/heads/master@{#351109}
5 years, 2 months ago (2015-09-28 19:29:24 UTC) #16
pavely
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1370343002/ by pavely@chromium.org. ...
5 years, 2 months ago (2015-09-28 22:10:53 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374653003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374653003/80001
5 years, 2 months ago (2015-09-29 10:50:59 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/110149)
5 years, 2 months ago (2015-09-29 12:28:16 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374653003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374653003/80001
5 years, 2 months ago (2015-09-29 12:30:16 UTC) #24
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 2 months ago (2015-09-29 13:07:33 UTC) #25
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 13:08:30 UTC) #26
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/0bbc9d23397f6c353186e86f34220f3f13e982b5
Cr-Commit-Position: refs/heads/master@{#351299}

Powered by Google App Engine
This is Rietveld 408576698