Add tests for Google Drive integration in chrome.fileSystem API on Chrome OS.

Add tests for Google Drive integration in chrome.fileSystem API on Chrome OS.

BUG=223464
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245230

[kinaba, 2014-01-15 08:08:45]

Sorry for keeping this postponed for a long while. Now I'm coming back...

I reused the test JS scripts 100% from existing tests, and just replaced the
test path to Drive path (by SkipPickerAndAlwaysSelectPathForTest). Hence, the
code added in this CL is mostly for setting up test harness for Drive backend.

+benwells: for the apps API side.
+hashimoto: for the Drive side.

[hashimoto, 2014-01-15 10:43:15]

lgtm with nits

https://codereview.chromium.org/137463006/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/file_system/file_system_apitest_chromeos.cc
(right):

https://codereview.chromium.org/137463006/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/file_system/file_system_apitest_chromeos.cc:1: //
Copyright (c) 2014 The Chromium Authors. All rights reserved.
nit: "(c)" is not needed.

https://codereview.chromium.org/137463006/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/file_system/file_system_apitest_chromeos.cc:90:
std::string AddTestDirectory(const std::string& title,
This function seems unused.

https://codereview.chromium.org/137463006/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/file_system/file_system_apitest_chromeos.cc:105:
drive::DriveIntegrationService* integration_service_;
nit: Please initialize these raw pointers in the ctor.

[benwells, 2014-01-15 21:29:01]

lgtm

I like the way you've reused the normal tests. Are you planning more for normal
files (e.g. for invalid access, missing files or whatever is there) or do you
think this is enough?

[kinaba, 2014-01-16 01:36:08]

https://codereview.chromium.org/137463006/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/file_system/file_system_apitest_chromeos.cc
(right):

https://codereview.chromium.org/137463006/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/file_system/file_system_apitest_chromeos.cc:1: //
Copyright (c) 2014 The Chromium Authors. All rights reserved.
On 2014/01/15 10:43:15, hashimoto wrote:
> nit: "(c)" is not needed.

Done.

https://codereview.chromium.org/137463006/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/file_system/file_system_apitest_chromeos.cc:90:
std::string AddTestDirectory(const std::string& title,
On 2014/01/15 10:43:15, hashimoto wrote:
> This function seems unused.

This will be used in the next patch coming soon.
Removed from the current CL and moved to the next one.

https://codereview.chromium.org/137463006/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/file_system/file_system_apitest_chromeos.cc:105:
drive::DriveIntegrationService* integration_service_;
On 2014/01/15 10:43:15, hashimoto wrote:
> nit: Please initialize these raw pointers in the ctor.

Done.

[kinaba, 2014-01-16 01:44:34]

On 2014/01/15 21:29:01, benwells wrote:
> lgtm
> 
> I like the way you've reused the normal tests. Are you planning more for
normal
> files (e.g. for invalid access, missing files or whatever is there) or do you
> think this is enough?

Some of the existing tests (cancellation, lastChooseEntry, permission ...) does
not have things specific to drive so I guess it can be omitted.
Some others (multiple files, invalid path, ...) may need something.
I'll check and probably craft a separate CL.

[commit-bot: I haz the power, 2014-01-16 02:10:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/137463006/120001

[commit-bot: I haz the power, 2014-01-16 08:10:10]

Retried try job too often on win_rel for step(s) base_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-16 08:11:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/137463006/120001

[commit-bot: I haz the power, 2014-01-16 17:28:09]

Change committed as 245230