Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 137463002: RenderFrame: flesh out Observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: More fixes Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 6ff7cea3fa7d2e6819e867c39700d2594abbb1e4..826056cc828a9554af32781c6e389c8dea5b8ca5 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -805,6 +805,10 @@ void RenderFrameImpl::didStartProvisionalLoad(blink::WebFrame* frame) {
RenderViewObserver, render_view_->observers(),
DidStartProvisionalLoad(frame));
+ FOR_EACH_OBSERVER(
+ RenderFrameObserver, observers_,
+ DidStartProvisionalLoad());
+
Send(new FrameHostMsg_DidStartProvisionalLoadForFrame(
routing_id_, frame->identifier(),
frame->parent() ? frame->parent()->identifier() : -1,
@@ -844,6 +848,9 @@ void RenderFrameImpl::didFailProvisionalLoad(
// Call out to RenderViewImpl, so observers are notified.
render_view_->didFailProvisionalLoad(frame, error);
+ FOR_EACH_OBSERVER(RenderFrameObserver, observers_,
+ DidFailProvisionalLoad(error));
+
bool show_repost_interstitial =
(error.reason == net::ERR_CACHE_MISS &&
EqualsASCII(failed_request.httpMethod(), "POST"));
@@ -1010,6 +1017,8 @@ void RenderFrameImpl::didFinishLoad(blink::WebFrame* frame) {
// TODO(nasko): Move implementation here. No state needed, just observers
// notification before sending message to the browser process.
render_view_->didFinishLoad(frame);
+ FOR_EACH_OBSERVER(RenderFrameObserver, observers_,
+ DidFinishLoad());
}
void RenderFrameImpl::didNavigateWithinPage(blink::WebFrame* frame,
@@ -1445,4 +1454,8 @@ void RenderFrameImpl::RemoveObserver(RenderFrameObserver* observer) {
observers_.RemoveObserver(observer);
}
+void RenderFrameImpl::OnStop() {
+ FOR_EACH_OBSERVER(RenderFrameObserver, observers_, OnStop());
+}
+
} // namespace content
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698