RenderFrame: flesh out Observer

content/public/renderer/render_frame_observer.h

Index: content/public/renderer/render_frame_observer.h
diff --git a/content/public/renderer/render_frame_observer.h b/content/public/renderer/render_frame_observer.h
index ceed692a51b89e20f7f63fe9285e013580a10aaf..cd4c15ddf89f39ca0cd20fe5501e322189df997f 100644
--- a/content/public/renderer/render_frame_observer.h
+++ b/content/public/renderer/render_frame_observer.h
@@ -13,6 +13,7 @@
 
 namespace blink {
 class WebFrame;
+struct WebURLError;
 }
 
 namespace content {
@@ -33,8 +34,15 @@ class CONTENT_EXPORT RenderFrameObserver : public IPC::Listener,
   // Called when a Pepper plugin is created.
   virtual void DidCreatePepperPlugin(RendererPpapiHost* host) {}
 
+  // Called when a load is stopped.

[nasko, 2014/01/28 20:41:39]

nit: This is explicitly stopped by the user/browser, so it might be useful to
clarify it in the comment.

[Elly Fong-Jones, 2014/01/28 21:34:20]

Done.

+  virtual void OnStop() {}
+
   // These match the Blink API notifications
   virtual void DidCommitProvisionalLoad(bool is_new_navigation) {}
+  virtual void DidStartProvisionalLoad() {}
+  virtual void DidFailProvisionalLoad(const blink::WebURLError& error) {}
+  virtual void DidFinishLoad() {}
+  virtual void DidAbortLoad() {}

[nasko, 2014/01/28 20:41:39]

Let's get rid of DidAbortLoad, as it was never in RVO and you are moving to
OnStop.

[Elly Fong-Jones, 2014/01/28 21:34:20]

Done.

 
   // IPC::Listener implementation.
   virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;