Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1374613002: [Interpreter] Add tests for adding strings and heap number arithmetic. (Closed)

Created:
5 years, 2 months ago by oth
Modified:
5 years, 2 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@oth-control-flow-runtime
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add tests for adding strings and heap number arithmetic. BUG=v8:4280 LOG=N Committed: https://crrev.com/003648772ae53c82c9fbfbe653acd62d61a17c42 Cr-Commit-Position: refs/heads/master@{#30986}

Patch Set 1 #

Patch Set 2 : Fix compilation for android. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -88 lines) Patch
M test/cctest/interpreter/test-interpreter.cc View 1 2 1 chunk +127 lines, -88 lines 0 comments Download
M test/unittests/runtime/runtime-interpreter-unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
oth
Please take a look at the changes to test-intpreter.cc. Thanks!
5 years, 2 months ago (2015-09-28 08:43:00 UTC) #2
rmcilroy
Looks great, thanks for doing this! Please fix the typo in the description / title, ...
5 years, 2 months ago (2015-09-28 09:49:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374613002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374613002/40001
5 years, 2 months ago (2015-09-28 18:38:53 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-09-28 19:14:24 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 19:14:38 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/003648772ae53c82c9fbfbe653acd62d61a17c42
Cr-Commit-Position: refs/heads/master@{#30986}

Powered by Google App Engine
This is Rietveld 408576698