Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3499)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java

Issue 1374603004: Refactor contextual search's panel host and scene layer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@extract-contextual-search
Patch Set: rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java
index ce31158ada7baf4e8c357816751b3e9913a38796..b587693b8d1a7bcce4184ebd33094630fc3a79e5 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java
@@ -8,8 +8,6 @@ import org.chromium.chrome.browser.ChromeActivity;
import org.chromium.chrome.browser.compositor.bottombar.OverlayContentDelegate;
import org.chromium.chrome.browser.compositor.bottombar.OverlayPanel.StateChangeReason;
import org.chromium.chrome.browser.compositor.bottombar.contextualsearch.ContextualSearchPanel;
-import org.chromium.chrome.browser.tab.Tab;
-import org.chromium.content_public.common.TopControlsState;
/**
* The delegate that provides global management functionality for Contextual Search.
@@ -37,17 +35,6 @@ public interface ContextualSearchManagementDelegate {
void logPromoOutcome();
/**
- * Updates the top controls state for the base tab. As these values are set at the renderer
- * level, there is potential for this impacting other tabs that might share the same
- * process. See {@link Tab#updateTopControlsState(int current, boolean animate)}
- * @param current The desired current state for the controls. Pass
- * {@link TopControlsState#BOTH} to preserve the current position.
- * @param animate Whether the controls should animate to the specified ending condition or
- * should jump immediately.
- */
- void updateTopControlsState(int current, boolean animate);
-
- /**
* Promotes the current Content View Core in the Contextual Search Panel to its own Tab.
*/
void promoteToTab();

Powered by Google App Engine
This is Rietveld 408576698