Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 13746: Experimental: thread live register references to deferred code.... (Closed)

Created:
12 years ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
iposva, William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Experimental: thread live register references to deferred code. Deferred code conceptually appears inline, but it is generated at the very end of a function. Since registers could be alive at entry and/or exit, it needs to know which ones. We take a snapshot of the global register file's reference counts and a copy of the virtual frame on entry, and use that to generate the deferred code. This requires the register file and frame to match for deferred code snippets with multiple incoming CFG edges. That's trivially true now because all uses of deferred code occur with fully spilled frames. Also included are fixes for some small lint issues.

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -99 lines) Patch
M src/codegen.h View 3 chunks +27 lines, -4 lines 0 comments Download
M src/codegen.cc View 1 3 chunks +42 lines, -5 lines 1 comment Download
M src/codegen-ia32.cc View 21 chunks +52 lines, -44 lines 1 comment Download
M src/jump-target-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/macro-assembler-ia32.cc View 1 chunk +3 lines, -13 lines 0 comments Download
M src/register-allocator-ia32.h View 3 chunks +27 lines, -1 line 0 comments Download
M src/register-allocator-ia32.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M src/virtual-frame-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/virtual-frame-ia32.h View 2 chunks +5 lines, -3 lines 0 comments Download
M src/virtual-frame-ia32.cc View 3 chunks +32 lines, -27 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
This should enable deferred code safely. There is still the general issue that we haven't ...
12 years ago (2008-12-11 16:35:40 UTC) #1
Kevin Millikin (Chromium)
12 years ago (2008-12-17 13:49:35 UTC) #2
I'm closing this issue, because I think we have a better way to do it.

Powered by Google App Engine
This is Rietveld 408576698