Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1374583003: Unnecessary 'translate to English' option is displayed in context menu in PDF. (Closed)

Created:
5 years, 2 months ago by Deepak
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

When we have viewing in a MimeHandlerViewGuest then translate will be disabled. This is needed as when context menu comes on the meterial UI buttons then these elements are not HTMLEmbedElements. so data.mediaType and data.mediaFlags values are not updated for these meterial UI toolbar. BUG=536679 Committed: https://crrev.com/06022f87156e51707901343b431a7213f873a510 Cr-Commit-Position: refs/heads/master@{#352246}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Changes as per review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 16 (4 generated)
Deepak
PTAL
5 years, 2 months ago (2015-09-28 13:25:08 UTC) #2
AKV
peer review looks good to me!
5 years, 2 months ago (2015-09-28 15:10:36 UTC) #3
Deepak
PTAL
5 years, 2 months ago (2015-09-28 15:20:25 UTC) #5
lazyboy
https://codereview.chromium.org/1374583003/diff/1/chrome/browser/renderer_context_menu/render_view_context_menu.cc File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right): https://codereview.chromium.org/1374583003/diff/1/chrome/browser/renderer_context_menu/render_view_context_menu.cc#newcode1170 chrome/browser/renderer_context_menu/render_view_context_menu.cc:1170: // If no |chrome_translate_client| attached with this webcontent or ...
5 years, 2 months ago (2015-09-29 04:41:58 UTC) #6
Deepak
@lazyboy Thanks for review. Changes done as suggested. PTAL https://codereview.chromium.org/1374583003/diff/1/chrome/browser/renderer_context_menu/render_view_context_menu.cc File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right): https://codereview.chromium.org/1374583003/diff/1/chrome/browser/renderer_context_menu/render_view_context_menu.cc#newcode1170 chrome/browser/renderer_context_menu/render_view_context_menu.cc:1170: ...
5 years, 2 months ago (2015-09-29 07:57:24 UTC) #7
Deepak
On 2015/09/29 07:57:24, Deepak wrote: > @lazyboy > Thanks for review. > Changes done as ...
5 years, 2 months ago (2015-10-01 13:19:42 UTC) #8
lazyboy
lgtm
5 years, 2 months ago (2015-10-02 18:06:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374583003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374583003/20001
5 years, 2 months ago (2015-10-03 05:44:36 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-03 06:20:15 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/06022f87156e51707901343b431a7213f873a510 Cr-Commit-Position: refs/heads/master@{#352246}
5 years, 2 months ago (2015-10-03 06:20:59 UTC) #13
katsmeowka.kw48
lgtm
5 years, 2 months ago (2015-10-17 05:41:03 UTC) #15
katsmeowka.kw48
5 years, 2 months ago (2015-10-17 05:48:58 UTC) #16
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698