Unnecessary 'translate to English' option is displayed in context menu in PDF.

When we have viewing in a MimeHandlerViewGuest then translate will be disabled.
This is needed as when context menu comes on the meterial UI buttons then these elements are not HTMLEmbedElements.
so data.mediaType and data.mediaFlags values are not updated for these meterial UI toolbar.

BUG=536679
Committed: https://crrev.com/06022f87156e51707901343b431a7213f873a510
Cr-Commit-Position: refs/heads/master@{#352246}

[Deepak, 2015-09-28 13:25:08]

deepak.m1@samsung.com changed reviewers:
+ ajith.v@chromium.org

[Deepak, 2015-09-28 13:25:08]

PTAL

[AKV, 2015-09-28 15:10:36]

peer review looks good to me!

[Deepak, 2015-09-28 15:20:24]

deepak.m1@samsung.com changed reviewers:
+ lazyboy@chromium.org

[Deepak, 2015-09-28 15:20:25]

PTAL

[lazyboy, 2015-09-29 04:41:58]

https://codereview.chromium.org/1374583003/diff/1/chrome/browser/renderer_con...
File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right):

https://codereview.chromium.org/1374583003/diff/1/chrome/browser/renderer_con...
chrome/browser/renderer_context_menu/render_view_context_menu.cc:1170: // If no
|chrome_translate_client| attached with this webcontent or we're
s/webcontent/WebContents

https://codereview.chromium.org/1374583003/diff/1/chrome/browser/renderer_con...
chrome/browser/renderer_context_menu/render_view_context_menu.cc:1173:
guest_view::GuestViewBase::IsGuest(source_web_contents_)) {
GuestViewBase seems too broad, to narrow it to mime handler views only, you'd
need !!MimeHandlerViewGuest::FromWebContents(..)

[Deepak, 2015-09-29 07:57:24]

@lazyboy
Thanks for review.
Changes done as suggested.
PTAL

https://codereview.chromium.org/1374583003/diff/1/chrome/browser/renderer_con...
File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right):

https://codereview.chromium.org/1374583003/diff/1/chrome/browser/renderer_con...
chrome/browser/renderer_context_menu/render_view_context_menu.cc:1170: // If no
|chrome_translate_client| attached with this webcontent or we're
On 2015/09/29 04:41:58, lazyboy wrote:
> s/webcontent/WebContents

Done.

https://codereview.chromium.org/1374583003/diff/1/chrome/browser/renderer_con...
chrome/browser/renderer_context_menu/render_view_context_menu.cc:1173:
guest_view::GuestViewBase::IsGuest(source_web_contents_)) {
On 2015/09/29 04:41:58, lazyboy wrote:
> GuestViewBase seems too broad, to narrow it to mime handler views only, you'd
> need !!MimeHandlerViewGuest::FromWebContents(..)

Done.

[Deepak, 2015-10-01 13:19:42]

On 2015/09/29 07:57:24, Deepak wrote:
> @lazyboy
> Thanks for review.
> Changes done as suggested.
> PTAL
> 
>
https://codereview.chromium.org/1374583003/diff/1/chrome/browser/renderer_con...
> File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right):
> 
>
https://codereview.chromium.org/1374583003/diff/1/chrome/browser/renderer_con...
> chrome/browser/renderer_context_menu/render_view_context_menu.cc:1170: // If
no
> |chrome_translate_client| attached with this webcontent or we're
> On 2015/09/29 04:41:58, lazyboy wrote:
> > s/webcontent/WebContents
> 
> Done.
> 
>
https://codereview.chromium.org/1374583003/diff/1/chrome/browser/renderer_con...
> chrome/browser/renderer_context_menu/render_view_context_menu.cc:1173:
> guest_view::GuestViewBase::IsGuest(source_web_contents_)) {
> On 2015/09/29 04:41:58, lazyboy wrote:
> > GuestViewBase seems too broad, to narrow it to mime handler views only,
you'd
> > need !!MimeHandlerViewGuest::FromWebContents(..)
> 
> Done.

Friendly Ping :)

[lazyboy, 2015-10-02 18:06:33]

lgtm

[Deepak, 2015-10-03 05:44:12]

The CQ bit was checked by deepak.m1@samsung.com

[commit-bot: I haz the power, 2015-10-03 05:44:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1374583003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1374583003/20001

[commit-bot: I haz the power, 2015-10-03 06:20:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-03 06:20:59]

Patchset 2 (id:??) landed as
https://crrev.com/06022f87156e51707901343b431a7213f873a510
Cr-Commit-Position: refs/heads/master@{#352246}

[katsmeowka.kw48, 2015-10-17 05:41:03]

katsmeowka.kw48@gmail.com changed reviewers:
+ katsmeowka.kw48@gmail.com

[katsmeowka.kw48, 2015-10-17 05:41:03]

lgtm

[katsmeowka.kw48, 2015-10-17 05:48:58]

lgtm