Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Issue 1374563010: Settings Rewrite: Restore id of default id to 'main' from ''. (Closed)

Created:
5 years, 2 months ago by tommycli
Modified:
5 years, 2 months ago
Reviewers:
dschuyler, Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org, Dan Beam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Settings Rewrite: Restore id of default id to 'main' from ''. Previously, the default subpage was marked as: <neon-animatable id=""> ... </neon-animatable> However, this is confusing. This patch changes the default subpage to: <neon-animatable id="main"> ... </neon-animatable> BUG=535013 Committed: https://crrev.com/88b850da08e4e919c8b1171003ad4e532d858aba Cr-Commit-Position: refs/heads/master@{#352438}

Patch Set 1 #

Patch Set 2 : #

Messages

Total messages: 9 (3 generated)
tommycli
dschuyler: PTAL, thanks!
5 years, 2 months ago (2015-10-05 18:46:23 UTC) #2
Dan Beam
lgtm
5 years, 2 months ago (2015-10-05 18:50:44 UTC) #4
dschuyler
On 2015/10/05 18:50:44, Dan Beam wrote: > lgtm lgtm
5 years, 2 months ago (2015-10-05 20:18:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374563010/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374563010/20001
5 years, 2 months ago (2015-10-05 20:50:59 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-05 21:51:43 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 21:52:31 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/88b850da08e4e919c8b1171003ad4e532d858aba
Cr-Commit-Position: refs/heads/master@{#352438}

Powered by Google App Engine
This is Rietveld 408576698