Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: lib/src/options.dart

Issue 1374563004: fix default warning level (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/options.dart
diff --git a/lib/src/options.dart b/lib/src/options.dart
index 962b5ceaf399790e06eea1ff170e0b63c2ccdb3c..7978c1091b36c72e63414305618f42401572464b 100644
--- a/lib/src/options.dart
+++ b/lib/src/options.dart
@@ -159,7 +159,7 @@ class CompilerOptions {
this.useColors: true,
this.help: false,
this.version: false,
- this.logLevel: Level.SEVERE,
+ this.logLevel: Level.WARNING,
this.serverMode: false,
this.enableHashing: false,
this.widget: true,
@@ -181,8 +181,7 @@ CompilerOptions parseOptions(List<String> argv, {bool forceOutDir: false}) {
if (enableHashing == null) {
enableHashing = serverMode;
}
- // TODO(jmesserly): shouldn't level always default to warning?
- var logLevel = serverMode ? Level.WARNING : Level.SEVERE;
+ var logLevel = Level.WARNING;
var levelName = args['log'];
if (levelName != null) {
levelName = levelName.toUpperCase();
@@ -313,7 +312,7 @@ final ArgParser argParser = StrongModeOptions.addArguments(new ArgParser()
defaultsTo: _CLOSURE_DEFAULT)
..addFlag('force-compile',
help: 'Compile code with static errors', defaultsTo: false)
- ..addOption('log', abbr: 'l', help: 'Logging level (defaults to severe)')
+ ..addOption('log', abbr: 'l', help: 'Logging level (defaults to warning)')
..addFlag('dump-info',
abbr: 'i', help: 'Dump summary information', defaultsTo: null)
..addOption('v8-binary',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698