Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1374533005: Add some owners to interpreter (Closed)

Created:
5 years, 2 months ago by rmcilroy
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add some owners to interpreter Adds the following owners to interpreter/ directory: - oth@chromium.org - mstarzinger@chromium.org - bmeurer@chromium.org Also sets noparent on the directory. Committed: https://crrev.com/cf036c6fd78b97e679d2e58b4831b27833527684 Cr-Commit-Position: refs/heads/master@{#31088}

Patch Set 1 #

Patch Set 2 : alphabetize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/interpreter/OWNERS View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
rmcilroy
Adding some owners, PTAL, thanks.
5 years, 2 months ago (2015-10-02 12:31:32 UTC) #2
Michael Starzinger
LGTM, I'll bite. Please alpha-sort the entries. And please also wait for Benedikt on whether ...
5 years, 2 months ago (2015-10-02 15:35:40 UTC) #3
Benedikt Meurer
On 2015/10/02 15:35:40, Michael Starzinger wrote: > LGTM, I'll bite. Please alpha-sort the entries. And ...
5 years, 2 months ago (2015-10-02 16:45:53 UTC) #4
rmcilroy
On 2015/10/02 16:45:53, Benedikt Meurer wrote: > On 2015/10/02 15:35:40, Michael Starzinger wrote: > > ...
5 years, 2 months ago (2015-10-02 17:05:09 UTC) #5
rmcilroy
On 2015/10/02 15:35:40, Michael Starzinger wrote: > LGTM, I'll bite. Please alpha-sort the entries. And ...
5 years, 2 months ago (2015-10-02 17:32:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374533005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374533005/20001
5 years, 2 months ago (2015-10-02 17:33:13 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-02 17:57:33 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/cf036c6fd78b97e679d2e58b4831b27833527684 Cr-Commit-Position: refs/heads/master@{#31088}
5 years, 2 months ago (2015-10-02 17:57:49 UTC) #11
Toon Verwaest
5 years, 2 months ago (2015-10-02 18:09:53 UTC) #13
Message was sent while issue was closed.
Sure, we'll do our part of reviewing. As I've mentioned before, I just need a
little bit of time to get back into action ;)

Powered by Google App Engine
This is Rietveld 408576698