Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1374533003: Remove NTP toasts that we no longer show. (Closed)

Created:
5 years, 2 months ago by aurimas (slooooooooow)
Modified:
5 years, 2 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove NTP toasts that we no longer show. BUG=None Committed: https://crrev.com/47605e5bc32cd3f313d5a3a293dae7f8154f6b23 Cr-Commit-Position: refs/heads/master@{#351186}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -30 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageToolbar.java View 2 chunks +1 line, -30 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
aurimas (slooooooooow)
PTAL
5 years, 2 months ago (2015-09-28 20:47:59 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374533003/1
5 years, 2 months ago (2015-09-28 20:49:10 UTC) #4
newt (away)
lgtm
5 years, 2 months ago (2015-09-28 21:18:06 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-28 21:40:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374533003/1
5 years, 2 months ago (2015-09-28 21:55:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 22:47:17 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 22:48:22 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/47605e5bc32cd3f313d5a3a293dae7f8154f6b23
Cr-Commit-Position: refs/heads/master@{#351186}

Powered by Google App Engine
This is Rietveld 408576698