third_party/WebKit/Source/core/frame/LocalDOMWindow.h - Issue 1374533002: Null out LocalDOMWindow::m_frame on navigation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalDOMWindow.h

Issue 1374533002: Null out LocalDOMWindow::m_frame on navigation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: try to fix crash-on-querying-event-path.html Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/LocalDOMWindow.h

diff --git a/third_party/WebKit/Source/core/frame/LocalDOMWindow.h b/third_party/WebKit/Source/core/frame/LocalDOMWindow.h

index 379590ec26d6df6030639b9cc269a54904d840bf..279ee89fc17732873663fed46f941b20c4d90435 100644

--- a/third_party/WebKit/Source/core/frame/LocalDOMWindow.h

+++ b/third_party/WebKit/Source/core/frame/LocalDOMWindow.h

@@ -223,13 +223,13 @@ private:

DECLARE_VIRTUAL_TRACE();

- private:

- WindowFrameObserver(LocalDOMWindow*, LocalFrame&);

// LocalFrameLifecycleObserver overrides:

void willDetachFrameHost() override;

void contextDestroyed() override;

+ private:

+ WindowFrameObserver(LocalDOMWindow*, LocalFrame&);

RawPtrWillBeMember<LocalDOMWindow> m_window;

};

friend WTF::OwnedPtrDeleter<WindowFrameObserver>;