third_party/WebKit/LayoutTests/http/tests/security/resources/xss-eval2.html - Issue 1374533002: Null out LocalDOMWindow::m_frame on navigation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/security/resources/xss-eval2.html

Issue 1374533002: Null out LocalDOMWindow::m_frame on navigation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: try to fix crash-on-querying-event-path.html Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/events/crash-on-querying-event-path.html ('K') | « third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/resources/popup-ready-to-navigate-child.html ('k') | third_party/WebKit/Source/core/frame/DOMWindow.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/security/resources/xss-eval2.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/security/resources/xss-eval2.html b/third_party/WebKit/LayoutTests/http/tests/security/resources/xss-eval2.html

index 462cd58d82be9321ac8e31f786aa4c62c938ac7f..33253cb3c03cc34eea1d2ee5b06f378fe93162a8 100644

--- a/third_party/WebKit/LayoutTests/http/tests/security/resources/xss-eval2.html

+++ b/third_party/WebKit/LayoutTests/http/tests/security/resources/xss-eval2.html

@@ -3,9 +3,15 @@ document.testExpando = "It's me too!";

parent.childEval = eval;

-parent.childEvalCaller = function(s) {

- return window.eval(s);

+parent.childEvalCaller = (function()

+ // Capture window.window into a variable, since this property always returns null once

+ // the context is navigated.

+ var w = window;

+ return function(s) {

+ return w.eval(s);

+ }

+})();

parent.childLocalEvalCaller = (function()

{