third_party/WebKit/LayoutTests/fast/dom/resources/javascript-url-crash-function-iframe.html - Issue 1374533002: Null out LocalDOMWindow::m_frame on navigation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/resources/javascript-url-crash-function-iframe.html

Issue 1374533002: Null out LocalDOMWindow::m_frame on navigation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: try to fix crash-on-querying-event-path.html Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/Window/resources/property-access-in-closure-after-navigation-child.html ('k') | third_party/WebKit/LayoutTests/fast/events/crash-on-querying-event-path.html » ('j') | third_party/WebKit/LayoutTests/fast/events/crash-on-querying-event-path.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/dom/resources/javascript-url-crash-function-iframe.html

diff --git a/third_party/WebKit/LayoutTests/fast/dom/resources/javascript-url-crash-function-iframe.html b/third_party/WebKit/LayoutTests/fast/dom/resources/javascript-url-crash-function-iframe.html

index 1d6a49d827fa53a94e728e8dbe6db0f266bdccbd..1520e08374d8b692394896dfb73062a5ebeaf5a3 100644

--- a/third_party/WebKit/LayoutTests/fast/dom/resources/javascript-url-crash-function-iframe.html

+++ b/third_party/WebKit/LayoutTests/fast/dom/resources/javascript-url-crash-function-iframe.html

@@ -15,8 +15,11 @@ function test()

setTimeout(function ()

{

+ // Capture window.window into a variable, since this property returns null as soon as the

+ // context is navigated.

+ var w = window;

test();

- if (window.testRunner)

- testRunner.notifyDone();

+ if (w.testRunner)

+ w.testRunner.notifyDone();

}, 0);

</script>